This is an archive of the discontinued LLVM Phabricator instance.

[Bazel] Fix layering issues
ClosedPublic

Authored by GMNGeoffrey on Jan 19 2023, 2:03 PM.

Details

Summary

These are caught by clang-16, which we're using in our project.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jan 19 2023, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 2:03 PM
GMNGeoffrey requested review of this revision.Jan 19 2023, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 2:03 PM
rupprecht accepted this revision.Jan 19 2023, 2:05 PM

I think I see why we don't see this failure internally (maybe), but I'm clueless as to why the buildkite builder or local builds don't complain. Anyway, thanks!

This revision is now accepted and ready to land.Jan 19 2023, 2:05 PM

I think I see why we don't see this failure internally (maybe), but I'm clueless as to why the buildkite builder or local builds don't complain. Anyway, thanks!

I think it's because they're using an older clang

This revision was automatically updated to reflect the committed changes.