This is an archive of the discontinued LLVM Phabricator instance.

'on_line' parameter added to DexExpectStepOrder in the Dexter syntax
ClosedPublic

Authored by BenJMudd on Jan 19 2023, 2:54 AM.

Details

Summary

DexExpectStepOrder uses the line to expect a debugger step from the actual line of the command in the Dexter source file. Now Dexter scripts have mainly moved to thier own script files instead of the actual source, there should be a option to override this behaviour to choose your own debugger step location

Diff Detail

Event Timeline

BenJMudd created this revision.Jan 19 2023, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 2:54 AM
BenJMudd requested review of this revision.Jan 19 2023, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 2:54 AM

We do need to refactor and clean up the delineation between command line of declaration and target line in the code at some point. This is fine in the meantime though and the patch looks good.

LGTM (with an inline question), thank you @BenJMudd!

cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py
22–23

This change seems a little bit suspicious - as mentioned offline perhaps this was doing the wrong thing before though. It does certainly look like no command classes ever set _on_line, so it looks like this is doing the right thing with your patch.

Have you checked the llvm-lit tests in cross-project-tests/debuginfo-tests/dexter/feature_tests pass (preferably on Linux as it has greater coverage)?

BenJMudd added inline comments.Jan 19 2023, 6:32 AM
cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py
22–23

Yep, just tested those tests on Linux both before and after removing this _on_line check, no difference in the output, they all pass, so I think it must have been doing the wrong thing before.

Orlando accepted this revision.Jan 19 2023, 6:47 AM
This revision is now accepted and ready to land.Jan 19 2023, 6:47 AM
BenJMudd marked an inline comment as done.Jan 19 2023, 6:58 AM
This revision was automatically updated to reflect the committed changes.