Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/CodeGen/AVR/inline-asm/inline-asm3.ll | ||
|---|---|---|
| 76 | Since no -mcpu option is specified in the test command, rcall is emitted as default instead of call. Because call is no valid for some early devices. | |
Comment Actions
Looks good to me, with just a single comment. Feel free to fix this while committing.
| llvm/lib/Target/AVR/AVRAsmPrinter.cpp | ||
|---|---|---|
| 147 | I think this should be the following, to be consistent with the rest of the code: if (Error && MO.getType() == MachineOperand::MO_GlobalAddress) {Even better would be to refactor the code to be more like RISC-V, to avoid the Error check (perhaps in a separate patch): bool RISCVAsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNo,
const char *ExtraCode, raw_ostream &OS) {
// First try the generic code, which knows about modifiers like 'c' and 'n'.
if (!AsmPrinter::PrintAsmOperand(MI, OpNo, ExtraCode, OS))
return false; | |
I think this should be the following, to be consistent with the rest of the code:
if (Error && MO.getType() == MachineOperand::MO_GlobalAddress) {Even better would be to refactor the code to be more like RISC-V, to avoid the Error check (perhaps in a separate patch):
bool RISCVAsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNo, const char *ExtraCode, raw_ostream &OS) { // First try the generic code, which knows about modifiers like 'c' and 'n'. if (!AsmPrinter::PrintAsmOperand(MI, OpNo, ExtraCode, OS)) return false;