This is an archive of the discontinued LLVM Phabricator instance.

Differential D142029

[Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag
ClosedPublic

Authored by Orlando on Jan 18 2023, 8:32 AM.

Details

Reviewers
jmorse
StephenTozer
Commits
rG0a996c82a75f: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag
Summary

This change allows -fexperimental-assignment-tracking to be negated using the negative equivalent -fno-experimental-assignment-tracking, and fixes the flag so that the default behaviour can be changed (currently the default is still false / disabled).

Diff Detail

Unit TestsFailed

TimeTest
3,880 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp

Event Timeline

Orlando created this revision.Jan 18 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 8:32 AM
Orlando requested review of this revision.Jan 18 2023, 8:32 AM
Orlando retitled this revision from [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag so it can be negated to [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag.Jan 18 2023, 8:35 AM
Orlando edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B208510: Diff 490178.Jan 18 2023, 10:13 AM
StephenTozer accepted this revision.Jan 19 2023, 1:16 AM
This revision is now accepted and ready to land.Jan 19 2023, 1:16 AM
This revision was landed with ongoing or failed builds.Jan 20 2023, 6:37 AM
Closed by commit rG0a996c82a75f: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag (authored by Orlando). · Explain Why
This revision was automatically updated to reflect the committed changes.
Orlando added a commit: rG0a996c82a75f: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag.
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 6:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
include/
clang/
Driver/
9 lines
test/
CodeGen/
assignment-tracking/
22 lines

Diff 490178

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,696 Lines • ▼ Show 20 Lines
def fdenormal_fp_math_f32_EQ : Joined<["-"], "fdenormal-fp-math-f32=">, def fdenormal_fp_math_f32_EQ : Joined<["-"], "fdenormal-fp-math-f32=">,
Group<f_Group>; Group<f_Group>;
def fctor_dtor_return_this : Flag<["-"], "fctor-dtor-return-this">, def fctor_dtor_return_this : Flag<["-"], "fctor-dtor-return-this">,
HelpText<"Change the C++ ABI to returning `this` pointer from constructors " HelpText<"Change the C++ ABI to returning `this` pointer from constructors "
"and non-deleting destructors. (No effect on Microsoft ABI)">, "and non-deleting destructors. (No effect on Microsoft ABI)">,
MarshallingInfoFlag<CodeGenOpts<"CtorDtorReturnThis">>; MarshallingInfoFlag<CodeGenOpts<"CtorDtorReturnThis">>;
def fexperimental_assignment_tracking : defm experimental_assignment_tracking :
Flag<["-"], "fexperimental-assignment-tracking">, Group<f_Group>, BoolOption<"f", "experimental-assignment-tracking",
HelpText<"Enable assignment tracking debug info">, CodeGenOpts<"EnableAssignmentTracking">, DefaultFalse,
MarshallingInfoFlag<CodeGenOpts<"EnableAssignmentTracking">>; PosFlag<SetTrue, [CC1Option]>, NegFlag<SetFalse>, BothFlags<[CoreOption]>>,
Group<f_Group>;
} // let Flags = [CC1Option, NoDriverOption] } // let Flags = [CC1Option, NoDriverOption]
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Dependency Output Options // Dependency Output Options
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
let Flags = [CC1Option, NoDriverOption] in { let Flags = [CC1Option, NoDriverOption] in {
▲ Show 20 Lines • Show All 1,393 Lines • Show Last 20 Lines

clang/test/CodeGen/assignment-tracking/flag.cpp

//// Explicitly enabled:
// RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone -O0 \ // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone -O0 \
// RUN: -emit-llvm -fexperimental-assignment-tracking %s -o - \ // RUN: -emit-llvm -fexperimental-assignment-tracking %s -o - \
// RUN: | FileCheck %s --check-prefixes=FLAG // RUN: | FileCheck %s --check-prefixes=ENABLE
//// Disabled by default:
// RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone -O0 \ // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone -O0 \
// RUN: -emit-llvm %s -o - \ // RUN: -emit-llvm %s -o - \
// RUN: | FileCheck %s --check-prefixes=NO-FLAG // RUN: | FileCheck %s --check-prefixes=DISABLE
//// Explicitly disabled:
// RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone -O0 \
// RUN: -emit-llvm %s -o - -fno-experimental-assignment-tracking \
// RUN: | FileCheck %s --check-prefixes=DISABLE
// Check some assignment-tracking stuff appears in the output when the flag // Check some assignment-tracking stuff appears in the output when the flag
// -fexperimental-assignment-tracking is used, and that it doesn't when // -fexperimental-assignment-tracking is used, that it doesn't when
// the flag is not used (default behaviour: no assignment tracking). // -fno-experimental-assignment-tracking is used or neither flag is specified.
// FLAG: DIAssignID // ENABLE: DIAssignID
// FLAG: dbg.assign // ENABLE: dbg.assign
// NO-FLAG-NOT: DIAssignID // DISABLE-NOT: DIAssignID
// NO-FLAG-NOT: dbg.assign // DISABLE-NOT: dbg.assign
void fun(int a) {} void fun(int a) {}