This is an archive of the discontinued LLVM Phabricator instance.

Differential D142023

[OpenMP] Disable building `libomptarget` on 32-bit systems
ClosedPublic

Authored by tianshilei1992 on Jan 18 2023, 7:44 AM.

Details

Reviewers
jdoerfert
jhuber6
Commits
rG57662cb2e375: [OpenMP] Disable building `libomptarget` on 32-bit systems
Summary

There are plenty of assumptions in libomptarget and the device runtime
about the pointer size or size_t, etc. 32-bit systems are not supported. There
is no point to refine whole things to make it portable. This patch simply disables
building on 32-bit systems.

Fix #60121.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 18 2023, 7:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 7:44 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
tianshilei1992 requested review of this revision.Jan 18 2023, 7:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 7:44 AM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B208494: Diff 490159.Jan 18 2023, 7:47 AM
tianshilei1992 edited the summary of this revision. (Show Details)Jan 18 2023, 7:50 AM
tianshilei1992 updated this revision to Diff 490163.Jan 18 2023, 7:52 AM

update one more

tianshilei1992 edited the summary of this revision. (Show Details)Jan 18 2023, 7:52 AM
Harbormaster completed remote builds in B208497: Diff 490163.Jan 18 2023, 7:55 AM
jdoerfert accepted this revision.Jan 18 2023, 10:37 AM

LG

openmp/CMakeLists.txt
77–78
This revision is now accepted and ready to land.Jan 18 2023, 10:37 AM
Closed by commit rG57662cb2e375: [OpenMP] Disable building `libomptarget` on 32-bit systems (authored by tianshilei1992). · Explain WhyJan 18 2023, 10:40 AM
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG57662cb2e375: [OpenMP] Disable building `libomptarget` on 32-bit systems.

Revision Contents

PathSize
openmp/
5 lines

Diff 490233

openmp/CMakeLists.txt

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Linesset(OPENMP_TEST_FLAGS "" CACHE STRING
"Extra compiler flags to send to the test compiler.") "Extra compiler flags to send to the test compiler.")
set(OPENMP_TEST_OPENMP_FLAGS ${OPENMP_TEST_COMPILER_OPENMP_FLAGS} CACHE STRING set(OPENMP_TEST_OPENMP_FLAGS ${OPENMP_TEST_COMPILER_OPENMP_FLAGS} CACHE STRING
"OpenMP compiler flag to use for testing OpenMP runtime libraries.") "OpenMP compiler flag to use for testing OpenMP runtime libraries.")
set(ENABLE_LIBOMPTARGET ON) set(ENABLE_LIBOMPTARGET ON)
# Currently libomptarget cannot be compiled on Windows or MacOS X. # Currently libomptarget cannot be compiled on Windows or MacOS X.
# Since the device plugins are only supported on Linux anyway, # Since the device plugins are only supported on Linux anyway,
# there is no point in trying to compile libomptarget on other OSes. # there is no point in trying to compile libomptarget on other OSes.
if (APPLE OR WIN32 OR NOT OPENMP_HAVE_STD_CPP17_FLAG) # 32-bit systems are not supported either.
if (APPLE OR WIN32 OR NOT OPENMP_HAVE_STD_CPP17_FLAG OR NOT CMAKE_SIZEOF_VOID_P EQUAL 8)
jdoerfertUnsubmitted
Not Done
ReplyInline Actions
# there is no point in trying to compile libomptarget on other OSes.
- # 32-bit systems are not supported as well.
+ # 32-bit systems are not supported either.
if (APPLE OR WIN32 OR NOT OPENMP_HAVE_STD_CPP17_FLAG OR NOT CMAKE_SIZEOF_VOID_P EQUAL 8)
jdoerfert:
set(ENABLE_LIBOMPTARGET OFF) set(ENABLE_LIBOMPTARGET OFF)
endif() endif()
option(OPENMP_ENABLE_LIBOMPTARGET "Enable building libomptarget for offloading." option(OPENMP_ENABLE_LIBOMPTARGET "Enable building libomptarget for offloading."
${ENABLE_LIBOMPTARGET}) ${ENABLE_LIBOMPTARGET})
option(OPENMP_ENABLE_LIBOMP_PROFILING "Enable time profiling for libomp." OFF) option(OPENMP_ENABLE_LIBOMP_PROFILING "Enable time profiling for libomp." OFF)
# Header install location # Header install location
Show All 9 Lines
add_subdirectory(runtime) add_subdirectory(runtime)
if (OPENMP_ENABLE_LIBOMPTARGET) if (OPENMP_ENABLE_LIBOMPTARGET)
# Check that the library can actually be built. # Check that the library can actually be built.
if (APPLE OR WIN32) if (APPLE OR WIN32)
message(FATAL_ERROR "libomptarget cannot be built on Windows and MacOS X!") message(FATAL_ERROR "libomptarget cannot be built on Windows and MacOS X!")
elseif (NOT OPENMP_HAVE_STD_CPP17_FLAG) elseif (NOT OPENMP_HAVE_STD_CPP17_FLAG)
message(FATAL_ERROR "Host compiler must support C++17 to build libomptarget!") message(FATAL_ERROR "Host compiler must support C++17 to build libomptarget!")
elseif (NOT CMAKE_SIZEOF_VOID_P EQUAL 8)
message(FATAL_ERROR "libomptarget on 32-bit systems are not supported!")
endif() endif()
add_subdirectory(libomptarget) add_subdirectory(libomptarget)
endif() endif()
set(ENABLE_OMPT_TOOLS ON) set(ENABLE_OMPT_TOOLS ON)
# Currently tools are not tested well on Windows or MacOS X. # Currently tools are not tested well on Windows or MacOS X.
if (APPLE OR WIN32) if (APPLE OR WIN32)
Show All 19 Lines