If the version number starts with cc1, such as: clang-cc1514432c58
In the test case the -cc1 option will match the version number instead of the command line. resulting in a check failure.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Thanks for the patch. I just have some simple suggestions.
clang/test/Driver/modules-ts.cpp | ||
---|---|---|
22–23 | An easier-to-understand fix is to simply combine this line and the next: // CHECK-USE: -cc1 {{.*}} -emit-obj | |
clang/test/OpenMP/driver.c | ||
6 | With -### on the command line, a better fix for this is: // CHECK-DEFAULT: "-cc1" |
clang/test/Driver/modules-ts.cpp | ||
---|---|---|
22–23 | Adding -### to this test totally changes the meaning of the test, and is not what I asked for. See lines 5 and 14 for examples of the correct approach. | |
clang/test/Driver/modules.cpp | ||
25–26 | Do not add -###, which totally changes the meaning of the test. See line 17 for an example of what you need to do here. |
An easier-to-understand fix is to simply combine this line and the next: