Page MenuHomePhabricator
Differential D141821

[C++20] [Modules] Deprecate `-fmodules-ts` flag
ClosedPublic
Actions

Authored by ChuanqiXu on Jan 15 2023, 11:53 PM.

Details

Reviewers
aaron.ballman
erichkeane
Group Reviewers
Restricted Project
Summary

Close https://github.com/llvm/llvm-project/issues/60060

See https://github.com/llvm/llvm-project/issues/60060 for details.

Diff Detail

Event Timeline

ChuanqiXu created this revision.Jan 15 2023, 11:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2023, 11:53 PM
ChuanqiXu requested review of this revision.Jan 15 2023, 11:53 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptJan 15 2023, 11:53 PM
Harbormaster completed remote builds in B207971: Diff 489440.Jan 16 2023, 1:04 AM
h-vetinari added a subscriber: h-vetinari.Jan 16 2023, 2:56 AM
h-vetinari added inline comments.
clang/include/clang/Basic/DiagnosticDriverKinds.td
635

Shouldn't this be something like:

ChuanqiXu updated this revision to Diff 489666.Jan 16 2023, 6:39 PM

Address comments.

ChuanqiXu marked an inline comment as done.Jan 16 2023, 6:40 PM
ChuanqiXu added inline comments.
clang/include/clang/Basic/DiagnosticDriverKinds.td
635

Yeah it is better. (we may assume -std=c++20 will be enabled if -std=c++23 is specified.)

Harbormaster completed remote builds in B208132: Diff 489666.Jan 16 2023, 7:38 PM
erichkeane accepted this revision.Jan 17 2023, 6:56 AM
This revision is now accepted and ready to land.Jan 17 2023, 6:56 AM
aaron.ballman accepted this revision.Jan 17 2023, 7:07 AM

LGTM, thank you!

ChuanqiXu closed this revision.Jan 17 2023, 6:51 PM
ChuanqiXu marked an inline comment as done.

Committed in https://reviews.llvm.org/rG98f36ac4fa86d7f7a3f05b70f792c416fbb23a4a
(I forgot to write the correct phab link)

Revision Contents
Changeset List

PathSize
clang/
docs/
2 lines
include/
clang/
Basic/
5 lines
lib/
Driver/
ToolChains/
1 line
test/
Driver/
5 lines

Diff 489666

View Options

clang/docs/ReleaseNotes.rst

Loading...
View Options

clang/include/clang/Basic/DiagnosticDriverKinds.td

Loading...
View Options

clang/lib/Driver/ToolChains/Clang.cpp

Loading...
View Options

clang/test/Driver/modules-ts.cpp

Loading...