This is an archive of the discontinued LLVM Phabricator instance.

Fixes a lint issue in the i386/ELF JitLink backend
ClosedPublic

Authored by jain98 on Jan 13 2023, 9:55 PM.

Details

Reviewers
lhames
sunho

Diff Detail

Event Timeline

jain98 created this revision.Jan 13 2023, 9:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 9:55 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
jain98 requested review of this revision.Jan 13 2023, 9:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 9:55 PM

I think you could just do default: break; but logging can be helpful at this stage of development I guess.

sunho accepted this revision.Jan 13 2023, 10:01 PM
This revision is now accepted and ready to land.Jan 13 2023, 10:01 PM

Seems like this was fixed in this commit by @chapuni .

jain98 closed this revision.Jan 13 2023, 10:41 PM
chapuni added inline comments.Jan 13 2023, 11:00 PM
llvm/lib/ExecutionEngine/JITLink/ELF_i386.cpp
196

If this debug message is useful, you may update.