This is an archive of the discontinued LLVM Phabricator instance.

Differential D141647

[clang][test] Remove unnecessary 'REQUIRES'
ClosedPublic

Authored by benshi001 on Jan 12 2023, 5:33 PM.

Details

Reviewers
aaron.ballman
MaskRay
Commits
rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES'
Summary

The test 'Preprocessor/predefined-arch-macros.c' contains many
target tests than 'amdgpu'. If clang is built without 'amdgpu',
then failures in other targets will not be reported.

Diff Detail

Event Timeline

benshi001 created this revision.Jan 12 2023, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 5:33 PM
Herald added subscribers: kosarev, tpr. · View Herald Transcript
benshi001 requested review of this revision.Jan 12 2023, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 5:33 PM
Herald added subscribers: cfe-commits, jacquesguan. · View Herald Transcript
MaskRay accepted this revision.Jan 12 2023, 5:49 PM
This revision is now accepted and ready to land.Jan 12 2023, 5:49 PM
MaskRay added a comment.Jan 12 2023, 5:50 PM

Unless there is something weird, -E does not need llvm/lib/Target code.

This revision was landed with ongoing or failed builds.Jan 12 2023, 6:04 PM
Closed by commit rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES' (authored by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES'.
Harbormaster completed remote builds in B207518: Diff 488818.Jan 12 2023, 6:14 PM

Revision Contents

PathSize
clang/
test/
Preprocessor/
1 line

Diff 488835

clang/test/Preprocessor/predefined-arch-macros.c

// REQUIRES: amdgpu-registered-target
// Begin X86/GCC/Linux tests ---------------- // Begin X86/GCC/Linux tests ----------------
// RUN: %clang -march=i386 -m32 -E -dM %s -o - 2>&1 \ // RUN: %clang -march=i386 -m32 -E -dM %s -o - 2>&1 \
// RUN: -target i386-unknown-linux \ // RUN: -target i386-unknown-linux \
// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_I386_M32 // RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_I386_M32
// CHECK_I386_M32: #define __LAHF_SAHF__ 1 // CHECK_I386_M32: #define __LAHF_SAHF__ 1
// CHECK_I386_M32: #define __i386 1 // CHECK_I386_M32: #define __i386 1
// CHECK_I386_M32: #define __i386__ 1 // CHECK_I386_M32: #define __i386__ 1
▲ Show 20 Lines • Show All 4,382 Lines • Show Last 20 Lines