[PowerPC] Use default attributes for more intrinsics

[shchenz]

LGTM. Thanks for improving this.

[amyk]

I think this LGTM as well.

llvm/include/llvm/IR/IntrinsicsPowerPC.td

let TargetPrefix = "ppc" in {  // All intrinsics start with "llvm.ppc.".
   def int_ppc_dcbt_with_hint: Intrinsic<[], [llvm_ptr_ty, llvm_i32_ty],
     [IntrArgMemOnly, NoCapture<ArgIndex<0>>, ImmArg<ArgIndex<1>>]>;
   def int_ppc_dcbtst_with_hint: Intrinsic<[], [llvm_ptr_ty, llvm_i32_ty],
     [IntrArgMemOnly, NoCapture<ArgIndex<0>>, ImmArg<ArgIndex<1>>]>;
   def int_ppc_dcbzl : Intrinsic<[], [llvm_ptr_ty], []>;
 
   // Get content from current FPSCR register
   def int_ppc_readflm : ClangBuiltin<"__builtin_readflm">,
-                        Intrinsic<[llvm_double_ty], [],
+                        DefaultAttrsIntrinsic<[llvm_double_ty], [],
                                               [IntrNoMerge, IntrHasSideEffects]>;
   // Set FPSCR register, and return previous content
   def int_ppc_setflm : ClangBuiltin<"__builtin_setflm">,
-                       Intrinsic<[llvm_double_ty], [llvm_double_ty],
+                       DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_double_ty],
                                              [IntrHasSideEffects]>;
 
   // Intrinsics for [double]word extended forms of divide instructions
   def int_ppc_divwe : ClangBuiltin<"__builtin_divwe">,
       DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty],
                             [IntrNoMem]>;
   def int_ppc_divweu : ClangBuiltin<"__builtin_divweu">,
       DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty],
                             [IntrNoMem]>;
   def int_ppc_divde : ClangBuiltin<"__builtin_divde">,
       DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty],
                             [IntrNoMem]>;
   def int_ppc_divdeu : ClangBuiltin<"__builtin_divdeu">,
       DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty],
                             [IntrNoMem]>;
 
   def int_ppc_unpack_longdouble : ClangBuiltin<"__builtin_unpack_longdouble">,
       DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_ppcf128_ty, llvm_i32_ty],
                             [IntrNoMem]>;
   def int_ppc_pack_longdouble : ClangBuiltin<"__builtin_pack_longdouble">,
       DefaultAttrsIntrinsic<[llvm_ppcf128_ty], [llvm_double_ty, llvm_double_ty],
                             [IntrNoMem]>;
 
   // Generate a random number
   def int_ppc_darn : ClangBuiltin<"__builtin_darn">,
-                     Intrinsic<[llvm_i64_ty], [],
+                     DefaultAttrsIntrinsic<[llvm_i64_ty], [],
                                            [IntrNoMerge, IntrHasSideEffects]>;
   def int_ppc_darnraw : ClangBuiltin<"__builtin_darn_raw">,
-                     Intrinsic<[llvm_i64_ty], [],
+                     DefaultAttrsIntrinsic<[llvm_i64_ty], [],
                                            [IntrNoMerge, IntrHasSideEffects]>;
   def int_ppc_darn32 : ClangBuiltin<"__builtin_darn_32">,
-                     Intrinsic<[llvm_i32_ty], [],
+                     DefaultAttrsIntrinsic<[llvm_i32_ty], [],
                                            [IntrNoMerge, IntrHasSideEffects]>;
 
   // Bit permute doubleword
   def int_ppc_bpermd : ClangBuiltin<"__builtin_bpermd">,
       DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty],
                             [IntrNoMem]>;
 
   // Parallel Bits Deposit/Extract Doubleword Builtins.
   def int_ppc_pdepd
def int_ppc_altivec_lvehx :
                             [IntrReadMem, IntrArgMemOnly]>;
   def int_ppc_altivec_lvewx :
       DefaultAttrsIntrinsic<[llvm_v4i32_ty], [llvm_ptr_ty],
                             [IntrReadMem, IntrArgMemOnly]>;
 
   // Stores.  These don't map directly to GCC builtins because they represent the
   // source address with a single pointer.
   def int_ppc_altivec_stvx :
-              Intrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
+              DefaultAttrsIntrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
                                     [IntrWriteMem, IntrArgMemOnly]>;
   def int_ppc_altivec_stvxl :
-              Intrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
+              DefaultAttrsIntrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
                                     [IntrWriteMem, IntrArgMemOnly]>;
   def int_ppc_altivec_stvebx :
-              Intrinsic<[], [llvm_v16i8_ty, llvm_ptr_ty],
+              DefaultAttrsIntrinsic<[], [llvm_v16i8_ty, llvm_ptr_ty],
                                     [IntrWriteMem, IntrArgMemOnly]>;
   def int_ppc_altivec_stvehx :
-              Intrinsic<[], [llvm_v8i16_ty, llvm_ptr_ty],
+              DefaultAttrsIntrinsic<[], [llvm_v8i16_ty, llvm_ptr_ty],
                                     [IntrWriteMem, IntrArgMemOnly]>;
   def int_ppc_altivec_stvewx :
-              Intrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
+              DefaultAttrsIntrinsic<[], [llvm_v4i32_ty, llvm_ptr_ty],
                                     [IntrWriteMem, IntrArgMemOnly]>;
 
   // Comparisons setting a vector.
   def int_ppc_altivec_vcmpbfp : ClangBuiltin<"__builtin_altivec_vcmpbfp">,
       DefaultAttrsIntrinsic<[llvm_v4i32_ty], [llvm_v4f32_ty, llvm_v4f32_ty],
                             [IntrNoMem]>;
   def int_ppc_altivec_vcmpeqfp : ClangBuiltin<"__builtin_altivec_vcmpeqfp">,
       DefaultAttrsIntrinsic<[llvm_v4i32_ty], [llvm_v4f32_ty, llvm_v4f32_ty],
                             [IntrNoMem]>;

 // We currently use llvm.ppc.cfence in the context of atomic load which
 // in LLVM IR requires its type to be one of integer, pointer and
 // float point type. So llvm_any_ty here refers to type mentioned above.
 // Backend is supposed to lower these types to appropriate MVTs.
 def int_ppc_cfence : Intrinsic<[], [llvm_any_ty], []>;
 
 // PowerPC set FPSCR Intrinsic Definitions.
 def int_ppc_setrnd : ClangBuiltin<"__builtin_setrnd">,
-      Intrinsic<[llvm_double_ty], [llvm_i32_ty], []>;
+      DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_i32_ty], [IntrHasSideEffects]>;
 }
 
 let TargetPrefix = "ppc" in {
   def int_ppc_vsx_assemble_pair :
       DefaultAttrsIntrinsic<[llvm_v256i1_ty],
                             [llvm_v16i8_ty, llvm_v16i8_ty], [IntrNoMem]>;
 
   def int_ppc_vsx_disassemble_pair :
let TargetPrefix = "ppc" in {
   def int_ppc_dcbtt : ClangBuiltin<"__builtin_ppc_dcbtt">,
                       Intrinsic<[], [llvm_ptr_ty],
                                 [IntrArgMemOnly, NoCapture<ArgIndex<0>>]>;
   def int_ppc_mftbu : ClangBuiltin<"__builtin_ppc_mftbu">,
       DefaultAttrsIntrinsic<[llvm_i32_ty], [], [IntrNoMem]>;
   def int_ppc_mfmsr : ClangBuiltin<"__builtin_ppc_mfmsr">,
       DefaultAttrsIntrinsic<[llvm_i32_ty], [], [IntrNoMem]>;
   def int_ppc_mfspr
-      : Intrinsic<[llvm_anyint_ty], [llvm_i32_ty], [ImmArg<ArgIndex<0>>]>;
+      : DefaultAttrsIntrinsic<[llvm_anyint_ty], [llvm_i32_ty], [ImmArg<ArgIndex<0>>]>;
   def int_ppc_mtmsr
       : ClangBuiltin<"__builtin_ppc_mtmsr">, Intrinsic<[], [llvm_i32_ty], []>;
   def int_ppc_mtspr
-      : Intrinsic<[], [llvm_i32_ty, llvm_anyint_ty], [ImmArg<ArgIndex<0>>]>;
+      : DefaultAttrsIntrinsic<[], [llvm_i32_ty, llvm_anyint_ty], [ImmArg<ArgIndex<0>>]>;
   def int_ppc_stfiw : ClangBuiltin<"__builtin_ppc_stfiw">,
-                      Intrinsic<[], [llvm_ptr_ty, llvm_double_ty],
+                      DefaultAttrsIntrinsic<[], [llvm_ptr_ty, llvm_double_ty],
                                             [IntrWriteMem]>;
   // compare
   def int_ppc_cmpeqb
       : ClangBuiltin<"__builtin_ppc_cmpeqb">,
         DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty],
                               [IntrNoMem]>;
   def int_ppc_cmprb
       : ClangBuiltin<"__builtin_ppc_cmprb">,
         DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty,
let TargetPrefix = "ppc" in {
   def int_ppc_fre
       : ClangBuiltin<"__builtin_ppc_fre">,
         DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_double_ty], [IntrNoMem]>;
   def int_ppc_fres
       : ClangBuiltin<"__builtin_ppc_fres">,
         DefaultAttrsIntrinsic<[llvm_float_ty], [llvm_float_ty], [IntrNoMem]>;
   def int_ppc_addex
       : ClangBuiltin<"__builtin_ppc_addex">,
-        Intrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty, llvm_i32_ty],
+        DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_i64_ty, llvm_i64_ty, llvm_i32_ty],
                               [IntrNoMem, IntrHasSideEffects, ImmArg<ArgIndex<2>>]>;
   def int_ppc_fsel : ClangBuiltin<"__builtin_ppc_fsel">,
       DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_double_ty, llvm_double_ty, 
                              llvm_double_ty], [IntrNoMem]>;
   def int_ppc_fsels : ClangBuiltin<"__builtin_ppc_fsels">,
       DefaultAttrsIntrinsic<[llvm_float_ty], [llvm_float_ty, llvm_float_ty,
                              llvm_float_ty], [IntrNoMem]>;
   def int_ppc_frsqrte : ClangBuiltin<"__builtin_ppc_frsqrte">,
       DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_double_ty], [IntrNoMem]>;
let TargetPrefix = "ppc" in {
   def int_ppc_compare_exp_gt : ClangBuiltin<"__builtin_ppc_compare_exp_gt">,
       DefaultAttrsIntrinsic<[llvm_i32_ty],
                             [llvm_double_ty, llvm_double_ty],
                             [IntrNoMem]>;
   def int_ppc_compare_exp_eq : ClangBuiltin<"__builtin_ppc_compare_exp_eq">,
       DefaultAttrsIntrinsic<[llvm_i32_ty], 
                             [llvm_double_ty, llvm_double_ty],
                             [IntrNoMem]>;
-  def int_ppc_test_data_class : Intrinsic<[llvm_i32_ty],
-                                          [llvm_anyfloat_ty, llvm_i32_ty],
-                                          [IntrNoMem, ImmArg<ArgIndex<1>>]>;
+  def int_ppc_test_data_class
+      : DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_anyfloat_ty, llvm_i32_ty],
   def int_ppc_fnabs
       : ClangBuiltin<"__builtin_ppc_fnabs">,
         DefaultAttrsIntrinsic<[llvm_double_ty], [llvm_double_ty], [IntrNoMem]>;
   def int_ppc_fnabss
       : ClangBuiltin<"__builtin_ppc_fnabss">,
         DefaultAttrsIntrinsic<[llvm_float_ty], [llvm_float_ty], [IntrNoMem]>;
 
   def int_ppc_convert_f128_to_ppcf128