With this change, libc-hdrgen is built like a host build tool like clang and used
to build libc for the target.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
| Time | Test | |
|---|---|---|
| 60,700 ms | x64 debian > Clang.Analysis::a_flaky_crash.cpp Script:
--
: 'RUN: at line 22'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -analyzer-checker=core -verify /var/lib/buildkite-agent/builds/llvm-project/clang/test/Analysis/a_flaky_crash.cpp
| |
| 60,890 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded::vloxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vloxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vloxseg.c
| |
| 61,300 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded::vluxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vluxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vluxseg.c
| |
| 62,280 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vloxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vloxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vloxseg.c
| |
| 62,570 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vluxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vluxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vluxseg.c
| |
| View Full Test Results (27 Failed) |
Event Timeline
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 362 | This can have potentially negative side-effects. Take for example Fuchsia's CMake cache file where on Darwin we set the generic flags which are passed to the "default" build as well as prefixed flags which are passed to target build. With this change, the generic flags will be passed to the target build and interfere with the prefixed flags. Can we avoid this change for now? | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 362 | To add some additional context, I'm planning major changes to how the "default" and target builds are set up, and after those changes, this should be possible without any negative side-effects, but that's going to take a few more weeks. | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 362 | The other option is to detect the libc specific options and pass them as CMAKE_ARGS. For now, we only need to test for LLVM_LIBC_FULL_BUILD. If that is OK, then we can avoid depending on prefixes. | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 362 | That would be my preference, at least for now. | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 362 | How does the latest diff look? | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 383–384 | Nit: this is unnecessary (uninitialized variables in CMake evaluate to empty string). | |
| 392–393 | This is slightly counterintuitive. I'd prefer introducing a special handling in llvm/CMakeLists.txt similarly to what we do for example for flang and mlir, see https://github.com/llvm/llvm-project/blob/830d116d776439093a16aad567cd3db2c4c3cd72/llvm/CMakeLists.txt#L143 and automatically including libc in LLVM_ENABLE_PROJECTS when libc is in LLVM_ENABLE_RUNTIMES. | |
| llvm/runtimes/CMakeLists.txt | ||
|---|---|---|
| 392–393 | I left this check here as a debug aid, but have also updated llvm/CMakeLists.txt according to your suggestion. | |
Comment Actions
Remove a spurious arg which was not removed when addressing the last round of comments.