Remove unnecessary template specifiers from truct constructors in tests.

[massberg]

Summary

As far as I can see they are unnecessary and in C++20 they lead to errors.
Removing them the tests pass with C++20 and the default version.
Example error message:

llvm-project/llvm/unittests/IR/PassBuilderCallbacksTest.cpp:275:30: error: expected unqualified-id before ‘)’ token
  275 |   MockAnalysisHandle<Module>() { setDefaults(); }

[ilya-biryukov]

LGTM to unbreak the buildbots, this change definitely does not change semantics.

I wonder what caused it to break in C++20, though. Any ideas?

[royjacobson]

It's dr2237, see https://github.com/llvm/llvm-project/issues/55164

[ilya-biryukov]

In D141358#4039265, @royjacobson wrote:

It's dr2237, see https://github.com/llvm/llvm-project/issues/55164

Thanks for the pointers! Clang does not seem to diagnose or forbid this even in trunk. I suspect the DR is not yet implemented, but there are other changes to the parser that cause these errors? 'Down with typename' maybe?

[royjacobson]

In D141358#4039268, @ilya-biryukov wrote:

In D141358#4039265, @royjacobson wrote:

It's dr2237, see https://github.com/llvm/llvm-project/issues/55164

Thanks for the pointers! Clang does not seem to diagnose or forbid this even in trunk. I suspect the DR is not yet implemented, but there are other changes to the parser that cause these errors? 'Down with typename' maybe?

I assumed the host compiler was GCC which should check for this... If this is actually an error when compiling with Clang it's pretty weird.

llvm/unittests/IR/PassBuilderCallbacksTest.cpp

: MockAnalysisHandleBase<MockAnalysisHandle<Loop>, Loop,
                              LoopStandardAnalysisResults &> {
 
   MOCK_METHOD3_T(run, typename Analysis::Result(Loop &, LoopAnalysisManager &,
                                                 LoopStandardAnalysisResults &));
 
   MOCK_METHOD3_T(invalidate, bool(Loop &, const PreservedAnalyses &,
                                   LoopAnalysisManager::Invalidator &));
 
-  MockAnalysisHandle<Loop>() { this->setDefaults(); }
+  MockAnalysisHandle() { this->setDefaults(); }
 };
 
 template <>
 struct MockAnalysisHandle<Function>
     : MockAnalysisHandleBase<MockAnalysisHandle<Function>, Function> {
   MOCK_METHOD2(run, Analysis::Result(Function &, FunctionAnalysisManager &));
 
   MOCK_METHOD3(invalidate, bool(Function &, const PreservedAnalyses &,
                                 FunctionAnalysisManager::Invalidator &));
 
-  MockAnalysisHandle<Function>() { setDefaults(); }
+  MockAnalysisHandle() { setDefaults(); }
 };
 
 template <>
 struct MockAnalysisHandle<LazyCallGraph::SCC>
     : MockAnalysisHandleBase<MockAnalysisHandle<LazyCallGraph::SCC>,
                              LazyCallGraph::SCC, CGSCCAnalysisManager,
                              LazyCallGraph &> {
   MOCK_METHOD3(run, Analysis::Result(LazyCallGraph::SCC &,
                                      CGSCCAnalysisManager &, LazyCallGraph &));
 
   MOCK_METHOD3(invalidate, bool(LazyCallGraph::SCC &, const PreservedAnalyses &,
                                 CGSCCAnalysisManager::Invalidator &));
 
-  MockAnalysisHandle<LazyCallGraph::SCC>() { setDefaults(); }
+  MockAnalysisHandle() { setDefaults(); }
 };
 
 template <>
 struct MockAnalysisHandle<Module>
     : MockAnalysisHandleBase<MockAnalysisHandle<Module>, Module> {
   MOCK_METHOD2(run, Analysis::Result(Module &, ModuleAnalysisManager &));
 
   MOCK_METHOD3(invalidate, bool(Module &, const PreservedAnalyses &,
                                 ModuleAnalysisManager::Invalidator &));
 
-  MockAnalysisHandle<Module>() { setDefaults(); }
+  MockAnalysisHandle() { setDefaults(); }
 };
 
 static std::unique_ptr<Module> parseIR(LLVMContext &C, const char *IR) {
   SMDiagnostic Err;
   return parseAssemblyString(IR, Err, C);
 }
 
 /// Helper for HasName matcher that returns getName both for IRUnit and