This is an archive of the discontinued LLVM Phabricator instance.

[perf-training] Check extension in findFilesWithExtension
ClosedPublic

Authored by Amir on Jan 9 2023, 6:14 PM.

Details

Summary

findFilesWithExtension helper checks for endswith(extension) instead of
exactly matching the file extension. This causes it to match unrelated files,
for example, .profdata files while matching .fdata files:

http://157.230.108.44:8011/#/builders/56/builds/247

Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/prof.fdata.1124569.fdata...
Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/test/Frontend/Output/optimization-remark-with-hotness-new-pm.c.tmp.profdata...

Diff Detail

Event Timeline

Amir created this revision.Jan 9 2023, 6:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 6:14 PM
Herald added a subscriber: pengfei. · View Herald Transcript
Amir requested review of this revision.Jan 9 2023, 6:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 6:14 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Jan 10 2023, 1:10 AM

LGTM

This revision is now accepted and ready to land.Jan 10 2023, 1:10 AM
This revision was automatically updated to reflect the committed changes.