This is an archive of the discontinued LLVM Phabricator instance.

Fix build when LLVM_BUILTIN_TARGETS is not set
ClosedPublic

Authored by kongyi on Jan 9 2023, 3:37 AM.

Details

Summary

If LLVM_BUILTIN_TARGETS is not set, no OS specific variants will be created, causing CMake build failure. Depend on the generic builtins target if LLVM_BUILTIN_TARGETS is not set.

Diff Detail

Event Timeline

kongyi created this revision.Jan 9 2023, 3:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 3:37 AM
kongyi requested review of this revision.Jan 9 2023, 3:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 3:37 AM
smeenai accepted this revision.Jan 9 2023, 8:53 PM

Ah, I didn't consider the case where you were using LLVM_RUNTIME_TARGETS but not LLVM_BUILTIN_TARGETS. Thanks.

This revision is now accepted and ready to land.Jan 9 2023, 8:53 PM
phosek accepted this revision.Jan 9 2023, 9:28 PM

LGTM

This revision was automatically updated to reflect the committed changes.