This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN] Init lsan and install at_exit hook
ClosedPublic

Authored by kstoimenov on Jan 6 2023, 10:25 AM.

Diff Detail

Event Timeline

kstoimenov created this revision.Jan 6 2023, 10:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 10:25 AM
kstoimenov requested review of this revision.Jan 6 2023, 10:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 10:25 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov abandoned this revision.Jan 6 2023, 10:25 AM

Create by mistake.

vitalybuka added inline comments.Jan 9 2023, 3:28 PM
compiler-rt/lib/hwasan/hwasan_allocator.cpp
246 ↗(On Diff #487013)

What is this for?

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp
188 ↗(On Diff #487013)

I recommend to extract a patches:

  1. flags
  2. InstallAtExitCheckLeaks

we will need patches:

  1. lsan tests in HWASAN, probably copied from asan
  2. hwasan tests in lsan, lsan already run asan tests, we need to enabled hwasan as well, on supported platforms

After pull.

vitalybuka added inline comments.Jan 12 2023, 2:09 PM
compiler-rt/lib/hwasan/hwasan_allocator.cpp
246 ↗(On Diff #487013)

What is this for?

ping

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp
188 ↗(On Diff #487013)

also allocator patch

After moving makefile.

Split out flags support.

vitalybuka added inline comments.Jan 13 2023, 1:44 PM
compiler-rt/lib/hwasan/hwasan.cpp
90

move into flags patch
we will remove this FIXME in the patch which enables hwasan testing in check-lsan

Don't use period in patch titles

vitalybuka retitled this revision from [HWASAN] Implemented LSAN in HWASAN. to [HWASAN] Implemented LSAN in HWASAN.Jan 18 2023, 12:07 AM
vitalybuka retitled this revision from [HWASAN] Implemented LSAN in HWASAN to [HWASAN] Init lsan and instal at_exit hook.
vitalybuka accepted this revision.Jan 18 2023, 12:13 AM
This revision is now accepted and ready to land.Jan 18 2023, 12:13 AM
kstoimenov retitled this revision from [HWASAN] Init lsan and instal at_exit hook to [HWASAN] Init lsan and install at_exit hook.Jan 18 2023, 3:39 PM
This revision was automatically updated to reflect the committed changes.