[HWASAN] Init lsan and install at_exit hook

[kstoimenov]

Create by mistake.

[kstoimenov]

Updated.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan_allocator.cpp

246 ↗

(On Diff #487013)

What is this for?

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

188 ↗

(On Diff #487013)

I recommend to extract a patches:

1. flags
2. InstallAtExitCheckLeaks

[vitalybuka]

we will need patches:

1. lsan tests in HWASAN, probably copied from asan
2. hwasan tests in lsan, lsan already run asan tests, we need to enabled hwasan as well, on supported platforms

[kstoimenov]

After pull.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan_allocator.cpp

246 ↗

(On Diff #487013)

What is this for?

ping

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

188 ↗

(On Diff #487013)

also allocator patch

[kstoimenov]

Split.

[kstoimenov]

After moving makefile.

[kstoimenov]

Split out flags support.

[kstoimenov]

Rebase.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan.cpp

90

move into flags patch
we will remove this FIXME in the patch which enables hwasan testing in check-lsan

[vitalybuka]

Don't use period in patch titles

[vitalybuka]

rebase

compiler-rt/lib/hwasan/hwasan.cpp

SetCommonFlagsDefaults();
     cf.check_printf = false;
     cf.intercept_tls_get_addr = true;
     cf.exitcode = 99;
     // 8 shadow pages ~512kB, small enough to cover common stack sizes.
     cf.clear_shadow_mmap_threshold = 4096 * (SANITIZER_ANDROID ? 2 : 8);
     // Sigtrap is used in error reporting.
     cf.handle_sigtrap = kHandleSignalExclusive;
     // FIXME: enable once all false positives have been fixed.
     cf.detect_leaks = false;
 
 #if SANITIZER_ANDROID
     // Let platform handle other signals. It is better at reporting them then we
     // are.
     cf.handle_segv = kHandleSignalNo;
     cf.handle_sigbus = kHandleSignalNo;
     cf.handle_abort = kHandleSignalNo;
     cf.handle_sigill = kHandleSignalNo;
     cf.handle_sigfpe = kHandleSignalNo;
 #endif
     OverrideCommonFlags(cf);
   }
 
   Flags *f = flags();
   f->SetDefaults();
 
   FlagParser parser;
   RegisterHwasanFlags(&parser, f);
   RegisterCommonFlags(&parser);
 
+#if CAN_SANITIZE_LEAKS
+  __lsan::Flags *lf = __lsan::flags();
+  lf->SetDefaults();
+
+  FlagParser lsan_parser;
+  __lsan::RegisterLsanFlags(&lsan_parser, lf);
+  RegisterCommonFlags(&lsan_parser);
+#endif
+
 #if HWASAN_CONTAINS_UBSAN
   __ubsan::Flags *uf = __ubsan::flags();
   uf->SetDefaults();
 
   FlagParser ubsan_parser;
   __ubsan::RegisterUbsanFlags(&ubsan_parser, uf);
   RegisterCommonFlags(&ubsan_parser);
 #endif
 
   // Override from user-specified string.
   if (__hwasan_default_options)
     parser.ParseString(__hwasan_default_options());
 #if HWASAN_CONTAINS_UBSAN
   const char *ubsan_default_options = __ubsan_default_options();
   ubsan_parser.ParseString(ubsan_default_options);
 #endif
 
   parser.ParseStringFromEnv("HWASAN_OPTIONS");
+#if CAN_SANITIZE_LEAKS
+  lsan_parser.ParseStringFromEnv("LSAN_OPTIONS");
+#endif
 #if HWASAN_CONTAINS_UBSAN
   ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
 #endif
 
   InitializeCommonFlags();
 
   if (Verbosity()) ReportUnrecognizedFlags();
 
   if (common_flags()->help) parser.PrintFlagDescriptions();
+  // Flag validation:
+  if (!CAN_SANITIZE_LEAKS && common_flags()->detect_leaks) {
+    Report("%s: detect_leaks is not supported on this platform.\n",
+           SanitizerToolName);
+    Die();
+  }
 }
 
 static void CheckUnwind() {
   GET_FATAL_STACK_TRACE_PC_BP(StackTrace::GetCurrentPc(), GET_CURRENT_FRAME());
   stack.Print();
 }
 
 static void HwasanFormatMemoryUsage(InternalScopedString &s) {