[HWASAN] Init lsan and install at_exit hook

[kstoimenov]

Create by mistake.

[kstoimenov]

Updated.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan_allocator.cpp

246 ↗

(On Diff #487013)

What is this for?

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

188

I recommend to extract a patches:

1. flags
2. InstallAtExitCheckLeaks

[vitalybuka]

we will need patches:

1. lsan tests in HWASAN, probably copied from asan
2. hwasan tests in lsan, lsan already run asan tests, we need to enabled hwasan as well, on supported platforms

[kstoimenov]

After pull.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan_allocator.cpp

246 ↗

(On Diff #487013)

What is this for?

ping

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

188

also allocator patch

[kstoimenov]

Split.

[kstoimenov]

After moving makefile.

[kstoimenov]

Split out flags support.

[kstoimenov]

Rebase.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan.cpp

90

move into flags patch
we will remove this FIXME in the patch which enables hwasan testing in check-lsan

[vitalybuka]

Don't use period in patch titles

[vitalybuka]

rebase

compiler-rt/lib/hwasan/hwasan.h

 void HwasanTSDInit();
 void HwasanTSDThreadInit();
 void HwasanAtExit();
 
 void HwasanOnDeadlySignal(int signo, void *info, void *context);
 
 void HwasanInstallAtForkHandler();
 
+void InstallAtExitCheckLeaks();
+
 void UpdateMemoryUsage();
 
 void AppendToErrorMessageBuffer(const char *buffer);
 
 void AndroidTestTlsSlot();
 
 // This is a compiler-generated struct that can be shared between hwasan
 // implementations.

compiler-rt/lib/hwasan/hwasan.cpp

SetCommonFlagsDefaults();
     cf.check_printf = false;
     cf.intercept_tls_get_addr = true;
     cf.exitcode = 99;
     // 8 shadow pages ~512kB, small enough to cover common stack sizes.
     cf.clear_shadow_mmap_threshold = 4096 * (SANITIZER_ANDROID ? 2 : 8);
     // Sigtrap is used in error reporting.
     cf.handle_sigtrap = kHandleSignalExclusive;
     // FIXME: enable once all false positives have been fixed.
     cf.detect_leaks = false;
 
 #if SANITIZER_ANDROID
     // Let platform handle other signals. It is better at reporting them then we
     // are.
     cf.handle_segv = kHandleSignalNo;
     cf.handle_sigbus = kHandleSignalNo;
     cf.handle_abort = kHandleSignalNo;
     cf.handle_sigill = kHandleSignalNo;
__attribute__((constructor(0))) void __hwasan_init() {
   InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir);
 
   HwasanTSDInit();
   HwasanTSDThreadInit();
 
   HwasanAllocatorInit();
   HwasanInstallAtForkHandler();
 
+  if (CAN_SANITIZE_LEAKS) {
+    __lsan::InitCommonLsan();
+    InstallAtExitCheckLeaks();
+  }
+
 #if HWASAN_CONTAINS_UBSAN
   __ubsan::InitAsPlugin();
 #endif
 
+  if (CAN_SANITIZE_LEAKS) {
+    __lsan::ScopedInterceptorDisabler disabler;
+    Symbolizer::LateInitialize();
+  } else {
+    Symbolizer::LateInitialize();
+  }
+
   VPrintf(1, "HWAddressSanitizer init done\n");
 
   hwasan_init_is_running = 0;
   hwasan_inited = 1;
 }
 
 void __hwasan_library_loaded(ElfW(Addr) base, const ElfW(Phdr) * phdr,
                              ElfW(Half) phnum) {

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

 
 // On linux, this just would call `atexit(HwasanAtExit)`. The functions in
 // HwasanAtExit are unimplemented for Fuchsia and effectively no-ops, so this
 // function is unneeded.
 void InstallAtExitHandler() {}
 
 void HwasanInstallAtForkHandler() {}
 
+void InstallAtExitCheckLeaks() {}
+
 void InitializeOsSupport() {
 #ifdef __aarch64__
   uint32_t features = 0;
   CHECK_EQ(zx_system_get_features(ZX_FEATURE_KIND_ADDRESS_TAGGING, &features),
            ZX_OK);
   if (!(features & ZX_ARM64_FEATURE_ADDRESS_TAGGING_TBI) &&
       flags()->fail_without_syscall_abi) {
     Printf(

compiler-rt/lib/hwasan/hwasan_interceptors.cpp

 #undef SIG_BLOCK
 #undef SIG_SETMASK
 
 #  endif  // HWASAN_WITH_INTERCEPTORS
 
 namespace __hwasan {
 
 int OnExit() {
+  if (CAN_SANITIZE_LEAKS && common_flags()->detect_leaks &&
+      __lsan::HasReportedLeaks()) {
+    return common_flags()->exitcode;
+  }
   // FIXME: ask frontend whether we need to return failure.
   return 0;
 }
 
 } // namespace __hwasan
 
 namespace __hwasan {
 

compiler-rt/lib/hwasan/hwasan_linux.cpp

void HwasanInstallAtForkHandler() {
   };
   auto after = []() {
     StackDepotUnlockAll();
     HwasanAllocatorUnlock();
   };
   pthread_atfork(before, after, after);
 }
 
+void InstallAtExitCheckLeaks() {
+  if (CAN_SANITIZE_LEAKS) {
+    if (common_flags()->detect_leaks && common_flags()->leak_check_at_exit) {
+      if (flags()->halt_on_error)
+        Atexit(__lsan::DoLeakCheck);
+      else
+        Atexit(__lsan::DoRecoverableLeakCheckVoid);
+    }
+  }
+}
+
 }  // namespace __hwasan
 
 #endif  // SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD