This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Add llvm-debuginfod as test dependency
ClosedPublic

Authored by luke on Jan 5 2023, 9:49 AM.

Details

Summary

llvm-debuginfod is used by llvm-lit as of
36f01909a0e29c1014301ed6835687a84bf0e9fa, so adding this dependency
fixes a "note: Did not find llvm-debuginfod" warning from showing up
when running tests.

Diff Detail

Event Timeline

luke created this revision.Jan 5 2023, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 9:49 AM
Herald added a subscriber: pmatos. · View Herald Transcript
luke requested review of this revision.Jan 5 2023, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 9:49 AM

Thanks, this LGTM. I see the comment mentions updating "test/lit.cfg" as well -- do you think this means llvm/test/lit.cfg.py? If so, we've already added the substitution there so we should be good.

noajshu accepted this revision.Jan 5 2023, 1:50 PM
This revision is now accepted and ready to land.Jan 5 2023, 1:50 PM
luke added a comment.Jan 6 2023, 2:18 AM

Thanks, this LGTM. I see the comment mentions updating "test/lit.cfg" as well -- do you think this means llvm/test/lit.cfg.py? If so, we've already added the substitution there so we should be good.

Yeah I believe so!

This revision was landed with ongoing or failed builds.Jan 6 2023, 2:19 AM
This revision was automatically updated to reflect the committed changes.