This is an archive of the discontinued LLVM Phabricator instance.

Differential D141013

amdgpu-arch: Prefer hsa/hsa.h over hsa.h
ClosedPublic

Authored by arsenm on Jan 4 2023, 1:40 PM.

Details

Reviewers
yaxunl
JonChesterfield
Summary

The header now prints a warning if you include hsa.h telling you to
include hsa/hsa.h

Diff Detail

Unit TestsFailed

TimeTest
920 msx64 debian > Profile-x86_64.Linux::counter_promo_for.c
830 msx64 debian > Profile-x86_64.Linux::counter_promo_while.c

Event Timeline

arsenm created this revision.Jan 4 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 1:40 PM
Herald added subscribers: kosarev, kerbowa, tpr and 3 others. · View Herald Transcript
arsenm requested review of this revision.Jan 4 2023, 1:40 PM
Herald added a subscriber: wdng. · View Herald TranscriptJan 4 2023, 1:40 PM
JonChesterfield accepted this revision.Jan 4 2023, 2:17 PM
This revision is now accepted and ready to land.Jan 4 2023, 2:17 PM
Harbormaster completed remote builds in B205763: Diff 486381.Jan 4 2023, 2:28 PM
arsenm closed this revision.Jan 4 2023, 5:55 PM

39a83ebd47fb56da5c1bd9dd976b70d551656cab

Revision Contents

PathSize
clang/
tools/
amdgpu-arch/
8 lines

Diff 486381

clang/tools/amdgpu-arch/AMDGPUArch.cpp

//===- AMDGPUArch.cpp - list AMDGPU installed ----------*- C++ -*---------===// //===- AMDGPUArch.cpp - list AMDGPU installed ----------*- C++ -*---------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file implements a tool for detecting name of AMDGPU installed in system // This file implements a tool for detecting name of AMDGPU installed in system
// using HSA. This tool is used by AMDGPU OpenMP driver. // using HSA. This tool is used by AMDGPU OpenMP driver.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#if defined(__has_include) #if defined(__has_include)
#if __has_include("hsa.h") #if __has_include("hsa/hsa.h")
#define HSA_HEADER_FOUND 1
#include "hsa.h"
#elif __has_include("hsa/hsa.h")
#define HSA_HEADER_FOUND 1 #define HSA_HEADER_FOUND 1
#include "hsa/hsa.h" #include "hsa/hsa.h"
#elif __has_include("hsa.h")
#define HSA_HEADER_FOUND 1
#include "hsa.h"
#else #else
#define HSA_HEADER_FOUND 0 #define HSA_HEADER_FOUND 0
#endif #endif
#else #else
#define HSA_HEADER_FOUND 0 #define HSA_HEADER_FOUND 0
#endif #endif
#if !HSA_HEADER_FOUND #if !HSA_HEADER_FOUND
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines