This is an archive of the discontinued LLVM Phabricator instance.

[MIPS] compiler-rt: Fix stat struct's size for O32 ABI
Needs ReviewPublic

Authored by raj.khem on Jan 3 2023, 8:15 PM.

Details

Reviewers
MaskRay
Summary

stat struct size differs on glibc based on ABI choices e.g. 64bit off_t
and/or 64bit time_t will make this size different. Therefore separate
out the O32 case out, makes it more readable.

Diff Detail

Event Timeline

raj.khem created this revision.Jan 3 2023, 8:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 8:15 PM
raj.khem requested review of this revision.Jan 3 2023, 8:15 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 3 2023, 8:15 PM

Is mips o32 still worth spending efforts? For mips perhaps we should only care about newer ABIs. Sanitizers are optional features anyway...

Is mips o32 still worth spending efforts? For mips perhaps we should only care about newer ABIs. Sanitizers are optional features anyway...

o32 is most prevalent mips32 ABI out in the field today (considering 32bit even 64bit mips ), IMO its important to fix o32.