llvm-reduce: Reduce prologue data

[arsenm]

Summary

Identical to the prefix data handling, and also had broken cloning.

[regehr]

llvm-reduce change is LGTM

I don't know the cloning code so can't contribute there

[nikic]

LG

[arsenm]

e60b0d2a2227a3fa299884bc3388baecdd4c88e6, with test name fixed to be consistent with API spelling

llvm/lib/Transforms/Utils/CloneFunction.cpp

#endif
   bool ModuleLevelChanges = Changes > CloneFunctionChangeType::LocalChangesOnly;
 
   // Copy all attributes other than those stored in the AttributeList.  We need
   // to remap the parameter indices of the AttributeList.
   AttributeList NewAttrs = NewFunc->getAttributes();
   NewFunc->copyAttributesFrom(OldFunc);
   NewFunc->setAttributes(NewAttrs);
 
+  const RemapFlags FuncGlobalRefFlags =
+      ModuleLevelChanges ? RF_None : RF_NoModuleLevelChanges;
+
   // Fix up the personality function that got copied over.
   if (OldFunc->hasPersonalityFn())
-    NewFunc->setPersonalityFn(
-        MapValue(OldFunc->getPersonalityFn(), VMap,
-                 ModuleLevelChanges ? RF_None : RF_NoModuleLevelChanges,
-                 TypeMapper, Materializer));
+    NewFunc->setPersonalityFn(MapValue(OldFunc->getPersonalityFn(), VMap,
+                                       FuncGlobalRefFlags, TypeMapper,
+                                       Materializer));
 
   if (OldFunc->hasPrefixData()) {
-    NewFunc->setPrefixData(
-        MapValue(OldFunc->getPrefixData(), VMap,
-                 ModuleLevelChanges ? RF_None : RF_NoModuleLevelChanges,
-                 TypeMapper, Materializer));
+    NewFunc->setPrefixData(MapValue(OldFunc->getPrefixData(), VMap,
+                                    FuncGlobalRefFlags, TypeMapper,
+                                    Materializer));
+  }
+
+  if (OldFunc->hasPrologueData()) {
+    NewFunc->setPrologueData(MapValue(OldFunc->getPrologueData(), VMap,
+                                      FuncGlobalRefFlags, TypeMapper,
+                                      Materializer));
   }
 
   SmallVector<AttributeSet, 4> NewArgAttrs(NewFunc->arg_size());
   AttributeList OldAttrs = OldFunc->getAttributes();
 
   // Clone any argument attributes that are present in the VMap.
   for (const Argument &OldArg : OldFunc->args()) {
     if (Argument *NewArg = dyn_cast<Argument>(VMap[&OldArg])) {

llvm/test/tools/llvm-reduce/reduce-prolog-data.ll

+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=function-data --test FileCheck --test-arg --check-prefix=CHECK --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck -check-prefixes=CHECK,RESULT %s < %t
+
+@gv = linkonce_odr global i32 1
+
+; CHECK: define void @drop_prologue_const_array()
+define void @drop_prologue_const_array() prologue [2 x i32] [i32 1, i32 2] {
+  ret void
+}
+
+; CHECK: define void @keep_prologue_const_array() prologue i32 1 {
+define void @keep_prologue_const_array() prologue i32 1 {
+  ret void
+}
+
+; CHECK: define void @drop_prologue_ptr_global()
+define void @drop_prologue_ptr_global() prologue ptr @gv {
+  ret void
+}
+
+; CHECK: define void @keep_prologue_ptr_global() prologue ptr @gv {
+define void @keep_prologue_ptr_global() prologue ptr @gv {
+  ret void
+}
+
+; Make sure there's no invalid reduction if the prologue data is really
+; accessed
+; CHECK: define i32 @drop_uses_prologue_const_array()
+define i32 @drop_uses_prologue_const_array() prologue [2 x i32] [i32 1, i32 2] {
+  %gep = getelementptr inbounds i32, ptr @drop_uses_prologue_const_array, i32 -1
+  %load = load i32, ptr %gep
+  ret i32 %load
+}
+
+; CHECK: define ptr @drop_uses_prologue_gv(
+define ptr @drop_uses_prologue_gv() prologue ptr @gv {
+  %gep = getelementptr inbounds i32, ptr @drop_uses_prologue_gv, i32 -1
+  %load = load ptr, ptr %gep
+  ret ptr %load
+}
+
+
+; RESULT: declare void @declaration_prologue_const_array(){{$}}
+declare void @declaration_prologue_const_array() prologue [2 x i32] [i32 1, i32 2]
+
+; RESULT: void @declaration_prologue_ptr_gv(){{$}}
+declare void @declaration_prologue_ptr_gv() prologue ptr @gv

llvm/tools/llvm-reduce/deltas/ReduceFunctionBodies.cpp

if (F.hasPersonalityFn()) {
           !O.shouldKeep()) {
         F.setPersonalityFn(nullptr);
       }
     }
 
     if (F.hasPrefixData() && !O.shouldKeep())
       F.setPrefixData(nullptr);
 
-    // TODO: Handle prologue data
+    if (F.hasPrologueData() && !O.shouldKeep())
+      F.setPrologueData(nullptr);
   }
 }
 
 void llvm::reduceFunctionDataDeltaPass(TestRunner &Test) {
   runDeltaPass(Test, reduceFunctionData, "Reducing Function Data");
 }