This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][JIT] Fixed a couple of issues in the initial implementation of JIT
ClosedPublic

Authored by tianshilei1992 on Dec 28 2022, 11:27 AM.

Details

Summary

This patch fixes a couple of issues:

  1. Instead of using llvm_unreachable for those base virtual functions, unknown value will be returned. The previous method could cause runtime error for those targets where the image is not compatible but JIT is not implemented.
  2. Fixed the type in CMake that causes the Target CMake variable is undefined.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 11:27 AM
tianshilei1992 requested review of this revision.Dec 28 2022, 11:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
ye-luo accepted this revision.Dec 28 2022, 11:31 AM
This revision is now accepted and ready to land.Dec 28 2022, 11:31 AM

better failure message