This is an archive of the discontinued LLVM Phabricator instance.

[cfi][CMake] Allow LoongArch
AbandonedPublic

Authored by Ami-zhang on Dec 27 2022, 11:43 PM.

Details

Summary

Adds build support for LoongArch64 linux to cfi.

Diff Detail

Event Timeline

Ami-zhang created this revision.Dec 27 2022, 11:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2022, 11:43 PM
Ami-zhang requested review of this revision.Dec 27 2022, 11:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2022, 11:43 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Ami-zhang retitled this revision from [compiler-rt] Add Loongarch64 support to CFI to [compiler-rt] Add LoongArch64 support to CFI.Dec 27 2022, 11:45 PM
MaskRay accepted this revision.Jan 4 2023, 6:01 PM

LGTM if ninja check-cfi passes on LoongArch.

Add LoongArch64 support to CFI

Perhaps [cfi][CMake] Allow LoongArch. Add .. support gives me a feeling of adding some code to make this happen. If this is trivially working, allow seems more appropriate.

This revision is now accepted and ready to land.Jan 4 2023, 6:01 PM

LGTM if ninja check-cfi passes on LoongArch.

Add LoongArch64 support to CFI

Perhaps [cfi][CMake] Allow LoongArch. Add .. support gives me a feeling of adding some code to make this happen. If this is trivially working, allow seems more appropriate.

The result of ninja check-cfi is all Unsupported, which is the same as X86's.
Ok, I have updated the title.
Thanks a lot.

Ami-zhang updated this revision to Diff 486474.Jan 4 2023, 11:25 PM

Update the title.

Ami-zhang retitled this revision from [compiler-rt] Add LoongArch64 support to CFI to [cfi][CMake] Allow LoongArch.Jan 4 2023, 11:25 PM
MaskRay requested changes to this revision.Jan 5 2023, 3:47 PM

This is not fine. You need to make ninja cfi work and make check-cfi run tests, not just blindly assuming it working.
I think some code in llvm/lib/Transforms/IPO/LowerTypeTests.cpp is needed.

This revision now requires changes to proceed.Jan 5 2023, 3:47 PM
Ami-zhang abandoned this revision.Jan 5 2023, 6:52 PM

This is not fine. You need to make ninja cfi work and make check-cfi run tests, not just blindly assuming it working.
I think some code in llvm/lib/Transforms/IPO/LowerTypeTests.cpp is needed.

Yes, the result of check-cfi is also not fine for me now.
Unsupported is one of the test results as other arch(e.g. x86), while the other test works has some failures caused by lld, which wil be fixed by others.
But it's the build support as described in the summary that count. This action referred to c172726f6f1476ead975e6e731fb95c4d1393e42.
Of course, if this action is not accepted now, i can abandon it first.

Ami-zhang reclaimed this revision.Jan 5 2023, 6:55 PM
This revision now requires changes to proceed.Jan 5 2023, 6:55 PM