This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers] Fix procmap tests for apple arm64
ClosedPublic

Authored by thetruestblue on Dec 22 2022, 11:09 AM.

Details

Summary

As part of effort to enable sanitizer common unit tests on arm64 apple devices.
Add kModuleArchARM64 as expected Arch
Apple Only change
rdar://101436019

Diff Detail

Event Timeline

thetruestblue created this revision.Dec 22 2022, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 11:09 AM
thetruestblue requested review of this revision.Dec 22 2022, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 11:09 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thetruestblue edited the summary of this revision. (Show Details)Dec 22 2022, 11:10 AM
thetruestblue edited the summary of this revision. (Show Details)
yln accepted this revision.Dec 22 2022, 3:37 PM
This revision is now accepted and ready to land.Dec 22 2022, 3:37 PM
This revision was landed with ongoing or failed builds.Jan 3 2023, 11:29 AM
This revision was automatically updated to reflect the committed changes.
kstoimenov added inline comments.
compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp
72

This is breaking one of our build bots: https://lab.llvm.org/buildbot/#/builders/77/builds/24399. You probably meant "arch == kModuleArchARM64". Do you mind either fixing forward or reverting?

Thanks!

thetruestblue marked an inline comment as done.
thetruestblue added inline comments.
compiler-rt/lib/sanitizer_common/tests/sanitizer_procmaps_test.cpp
72

fixed long line