This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Add support of ptxas v12.0 to the LIT tests
AbandonedPublic

Authored by pavelkopyl on Dec 20 2022, 3:11 PM.

Details

Reviewers
tra
Summary

Kepler architecture support was removed from CUDA 12.0.
Skip tests that target to Kepler architecture when using ptxas v12.0.

Diff Detail

Event Timeline

pavelkopyl created this revision.Dec 20 2022, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 3:11 PM
pavelkopyl requested review of this revision.Dec 20 2022, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 3:11 PM
tra added a comment.Jan 4 2023, 11:44 AM

Description could use some details. I.e. what makes sm_35 special? I assume it's due to the fact that sm_35 is no longer supported.

Instead of special-casing ptxas-12.0, perhpas a better way is to just always run ptxas with -arch=sm_60 so it would work with ptxas from all reasonably new CUDA versions.

llvm/test/lit.cfg.py
215–216

There are also 11.7 and 11.8.

pavelkopyl edited the summary of this revision. (Show Details)Jan 9 2023, 4:28 PM

Description could use some details. I.e. what makes sm_35 special? I assume it's due to the fact that sm_35 is no longer supported.

Instead of special-casing ptxas-12.0, perhpas a better way is to just always run ptxas with -arch=sm_60 so it would work with ptxas from all reasonably new CUDA versions.

Thank you. I've added details to the description.

As for choosing to an actual ptxas version, yes we could do this.
But original motivation to use minimal possible version of architecture/PTX was to catch errors related to appearance of new instructions and adding appropriate checks to the codegen. For example, https://reviews.llvm.org/D123040
On the other hand, all such cases seems to have been detected and fixed for old architectures, so we could focus on current ones.

llvm/test/lit.cfg.py
215–216

Done, thank you.

I've prepared a new review where ptxas is run -march=sm_60: https://reviews.llvm.org/D141736