This is an archive of the discontinued LLVM Phabricator instance.

Replace void* with std::byte* in AsyncRuntime
ClosedPublic

Authored by yijia1212 on Dec 20 2022, 12:48 PM.

Details

Summary

Replace void* with std::byte* in AsyncRuntime to make it clear that these pointers point to a memory region.

Diff Detail

Event Timeline

yijia1212 created this revision.Dec 20 2022, 12:48 PM
yijia1212 requested review of this revision.Dec 20 2022, 12:48 PM
ezhulenev added inline comments.Dec 20 2022, 5:46 PM
mlir/include/mlir/ExecutionEngine/AsyncRuntime.h
19

Build is failing, looks like it's missing <cstddef>

yijia1212 updated this revision to Diff 484440.Dec 20 2022, 6:07 PM

Add cstddef header include

yijia1212 marked an inline comment as done.Dec 20 2022, 6:08 PM
ezhulenev accepted this revision.Dec 20 2022, 6:59 PM
This revision is now accepted and ready to land.Dec 20 2022, 6:59 PM
This revision was automatically updated to reflect the committed changes.