This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][NFC] adding an option to keep the test point
ClosedPublic

Authored by shchenz on Dec 19 2022, 7:46 PM.

Details

Reviewers
nemanjai
Group Reviewers
Restricted Project
Commits
rGdd0edc876cfe: [PowerPC][NFC] add an option to keep the test point
Summary
Passes before hardware loop insertion change the loop to a form which
is not a hardware loop candidate (return early before checking the ctr clobbers).
And the PHI in the loop exit block is also optimized away. This breaks the
previous test point when the case was committed. Fixing this by running this
case just before hardware loop insertion pass.

Diff Detail

Event Timeline

shchenz created this revision.Dec 19 2022, 7:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 7:46 PM
shchenz requested review of this revision.Dec 19 2022, 7:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 7:46 PM

gentle ping

nemanjai accepted this revision.Jan 5 2023, 7:12 AM

LGTM.

llvm/test/CodeGen/PowerPC/pr48527.ll
2

Please add a note such as:

; NOTE: this needs to run starting at HW loops to ensure that
; the original loop does not end up producing a HW loop. If
; other passes are run prior, the loop will be transformed.
This revision is now accepted and ready to land.Jan 5 2023, 7:12 AM
This revision was automatically updated to reflect the committed changes.