Disable Univariate3D_Invert to workaround module build failure

[steven_wu]

Summary

Disable test to workaround build failures when bootstrap with modules:
https://github.com/llvm/llvm-project/issues/59562

[steven_wu]

Fix typo

[sdesmalen]

llvm/unittests/Support/LinearPolyBaseTest.cpp

171

I'm not sure that I understand either the problem or the solution :)

Is there a bug in Clang that this doesn't compile correctly when using modules? Or is there perhaps something wrong with the implementation of operator- (e.g. it not being correct/compliant yet GCC/Clang always accepted it).

Is this failure somehow specific to Darwin?

[steven_wu]

llvm/unittests/Support/LinearPolyBaseTest.cpp

171

I think Darwin bots is the only one that runs module build from a bootstrapped compiler. I don't know this affect other platform, most likely yes. Unfortunately we don't have a flag to check if module is enabled (?). This is not a bug fix, just to get the bots green again.

This is a bug in clang module I think. @vsapsai can comment on it more but some changes in clang frontend triggered the failure. Unfortunately, the bots was broken for a long time so we can't revert cleanly the offending commits when we find it. Temporarily disable this test on Darwin bots so we can caught regression like this earlier.

llvm/unittests/Support/LinearPolyBaseTest.cpp

 }
 
 TEST(UnivariateLinearPolyBase, Univariate3D_Scale) {
   // Test operator*
   EXPECT_EQ(Univariate3D(4, 0) * 2, Univariate3D(8, 0));
   EXPECT_EQ(Univariate3D(4, 1) * -2, Univariate3D(-8, 1));
 }
 
+#ifndef __APPLE__
+// FIXME: workaround for module build failures:
+// https://github.com/llvm/llvm-project/issues/59562
 TEST(UnivariateLinearPolyBase, Univariate3D_Invert) {
   // Test operator-
   EXPECT_EQ(-Univariate3D(4, 0), Univariate3D(-4, 0));
   EXPECT_EQ(-Univariate3D(4, 1), Univariate3D(-4, 1));
 }
-
+#endif