[libclang] Remove redundant return statements in CXType.cpp

[emilio]

Summary

Let the branch fall through the error path like other functions here do.

[emilio]

Remove gratuitious whitespace changes

[emilio]

Unclear to me who to request review from, so I'm peeking reviewer based on the git log. Please feel free to review or forward to someone else as appropriate. Thanks in advance!

[emilio]

rebase

[serge-sans-paille]

The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint?

[emilio]

In D140074#4159583, @serge-sans-paille wrote:

The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint?

I was just reading through the code.

clang/tools/libclang/CXType.cpp

CXType clang_getTypedefDeclUnderlyingType(CXCursor C) {
 
   if (clang_isDeclaration(C.kind)) {
     const Decl *D = cxcursor::getCursorDecl(C);
 
     if (const TypedefNameDecl *TD = dyn_cast_or_null<TypedefNameDecl>(D)) {
       QualType T = TD->getUnderlyingType();
       return MakeCXType(T, TU);
     }
-
-    return MakeCXType(QualType(), TU);
   }
 
   return MakeCXType(QualType(), TU);
 }
 
 CXType clang_getEnumDeclIntegerType(CXCursor C) {
   using namespace cxcursor;
   CXTranslationUnit TU = cxcursor::getCursorTU(C);
 
   if (clang_isDeclaration(C.kind)) {
     const Decl *D = cxcursor::getCursorDecl(C);
 
     if (const EnumDecl *TD = dyn_cast_or_null<EnumDecl>(D)) {
       QualType T = TD->getIntegerType();
       return MakeCXType(T, TU);
     }
-
-    return MakeCXType(QualType(), TU);
   }
 
   return MakeCXType(QualType(), TU);
 }
 
 long long clang_getEnumConstantDeclValue(CXCursor C) {
   using namespace cxcursor;
 
   if (clang_isDeclaration(C.kind)) {
     const Decl *D = cxcursor::getCursorDecl(C);
 
     if (const EnumConstantDecl *TD = dyn_cast_or_null<EnumConstantDecl>(D)) {
       return TD->getInitVal().getSExtValue();
     }
-
-    return LLONG_MIN;
   }
 
   return LLONG_MIN;
 }
 
 unsigned long long clang_getEnumConstantDeclUnsignedValue(CXCursor C) {
   using namespace cxcursor;
 
   if (clang_isDeclaration(C.kind)) {
     const Decl *D = cxcursor::getCursorDecl(C);
 
     if (const EnumConstantDecl *TD = dyn_cast_or_null<EnumConstantDecl>(D)) {
       return TD->getInitVal().getZExtValue();
     }
-
-    return ULLONG_MAX;
   }
 
   return ULLONG_MAX;
 }
 
 int clang_getFieldDeclBitWidth(CXCursor C) {
   using namespace cxcursor;