This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] make doc for SLS_Inline more clearly
ClosedPublic

Authored by Backl1ght on Dec 13 2022, 7:34 AM.

Diff Detail

Event Timeline

Backl1ght created this revision.Dec 13 2022, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 7:34 AM
Backl1ght requested review of this revision.Dec 13 2022, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 7:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

MyDeveloperDay requested changes to this revision.Dec 13 2022, 9:21 AM

I'm not sure if that is correct, as that doesn't fit the example (unless the example is wrong)

It feels like its saying merge if its an argument of a function (sort in this case)

sort(a.begin(), a.end(), []() { return x < y; });

The lambda is the argument, not that the lamda has no arguments? either way something isn't correct by making that change (either the description was wrong as well as the example or now the description doesn't match the example)

This revision now requires changes to proceed.Dec 13 2022, 9:21 AM

Seems like I have misunderstood it, after some test I'm sure that it means merge if its an argument of a function.

I think there are something todo to make the doc more clearly.

Backl1ght updated this revision to Diff 482530.Dec 13 2022, 9:54 AM
Backl1ght retitled this revision from [clang-format] fix typo in doc for SLS_Inline to [clang-format] make doc for SLS_Inline more clearly.

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

Let me rephrase it. Why should you think that you do it wrong?

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

Let me rephrase it. Why should you think that you do it wrong?

I don't think such typo can exist for 4 years so I think maybe I understand it wrongly. And it turned out that I do understand it in the wrong way.

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

Let me rephrase it. Why should you think that you do it wrong?

For "Am I doing it wrong" I mean I am not sure if what I do in diff1 is correct.

MyDeveloperDay accepted this revision.Dec 14 2022, 6:08 AM

I think given that it confused you I'm fine with this change

This revision is now accepted and ready to land.Dec 14 2022, 6:08 AM
This revision was landed with ongoing or failed builds.Dec 15 2022, 5:09 AM
This revision was automatically updated to reflect the committed changes.