This is an archive of the discontinued LLVM Phabricator instance.

[NFC] [Doc] Fix example for AnnotateTypeDocs
ClosedPublic

Authored by python3kgae on Dec 13 2022, 7:20 AM.

Details

Summary

Change clang::annotate into clang::annotate_type.

The example will get error like
error: 'annotate' attribute cannot be applied to types
int* [[clang::annotate("category1", "foo", 1)]] f(int[[clang::annotate("category2")]] *);

Diff Detail

Event Timeline

python3kgae created this revision.Dec 13 2022, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 7:20 AM
python3kgae requested review of this revision.Dec 13 2022, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 7:20 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Merry Christmas and ping

Happy new year and ping

I don't particularly know what the intent here was, so I'm hoping that @mboehme will review when he gets back from whatever vacation he's taking.

aaron.ballman accepted this revision.Jan 5 2023, 1:25 PM

LGTM, thank you!

This revision is now accepted and ready to land.Jan 5 2023, 1:25 PM
This revision was landed with ongoing or failed builds.Jan 5 2023, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Sorry for the delay.

Just to confirm, yes this should of course be annotate_type. Thanks for catching my mistake.

@aaron.ballman Thanks for reviewing!