This is an archive of the discontinued LLVM Phabricator instance.

[flang] Perform polymorphic pointer association with runtime call
ClosedPublic

Authored by clementval on Dec 12 2022, 2:44 AM.

Details

Summary

pointer association to a polymorphic pointer needs to potentially
update the element size in the descriptor. Update the pointer association
to polymoprhic pointer with a runtime call to PointerAssociate.

Diff Detail

Event Timeline

clementval created this revision.Dec 12 2022, 2:44 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 12 2022, 2:44 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Dec 12 2022, 2:44 AM
jeanPerier accepted this revision.Dec 12 2022, 4:49 AM

LGTM (beware of the CompilerInvocation.cpp change though).

flang/lib/Frontend/CompilerInvocation.cpp
957 ↗(On Diff #482048)

Unintentional ?

This revision is now accepted and ready to land.Dec 12 2022, 4:49 AM
clementval added inline comments.Dec 12 2022, 5:03 AM
flang/lib/Frontend/CompilerInvocation.cpp
957 ↗(On Diff #482048)

Yeah probably the 10th times I forgot to remove it :( Thanks for spotting it.