This is an archive of the discontinued LLVM Phabricator instance.

[HLSL] Add trunc library function
ClosedPublic

Authored by bob80905 on Dec 9 2022, 2:22 PM.

Diff Detail

Event Timeline

bob80905 created this revision.Dec 9 2022, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 2:22 PM
Herald added a subscriber: Anastasia. · View Herald Transcript
bob80905 requested review of this revision.Dec 9 2022, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 2:22 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
bob80905 updated this revision to Diff 481747.Dec 9 2022, 2:24 PM

dont just paste the clang format commit onto the revision

bob80905 updated this revision to Diff 481748.Dec 9 2022, 2:24 PM

The commit still isn't included, adding ^ character

The PR title is acos but trunc is added.

bob80905 retitled this revision from [HLSL] Add acos library function to [HLSL] Add trunc library function.Dec 9 2022, 3:34 PM
python3kgae accepted this revision.Dec 9 2022, 4:25 PM

LGTM.
Remember to double check the commit message updated to trunc too.

Just noticed we don't have double trunc(double) for hlsl now (hlsl 2021). Need make sure to generate float overload DXIL on older shader model when parameter is double in hlsl.

This revision is now accepted and ready to land.Dec 9 2022, 4:25 PM
This revision was automatically updated to reflect the committed changes.