This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Object] Include header `BitcodeReader.h` instead of using forward declaration for BitcodeModule
ClosedPublic

Authored by tianshilei1992 on Dec 7 2022, 10:45 AM.

Details

Summary

BitcodeModule is used as element of a vector in IRSymtabFile, while in the
header there is only a forward declaration. It will work if the header BitcodeReader.h
is included before including IRObjectFile.h. However, it is not always the case,
causing compilation error. This patch simply includes the header and remove the
forward declaration.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Dec 7 2022, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 10:45 AM
tianshilei1992 requested review of this revision.Dec 7 2022, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 10:45 AM
This revision is now accepted and ready to land.Dec 7 2022, 12:08 PM
This revision was landed with ongoing or failed builds.Dec 7 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.