This is an archive of the discontinued LLVM Phabricator instance.

Differential D139547

[NFC] Correct argument comment typo
ClosedPublic

Authored by gAlfonso-bit on Dec 7 2022, 8:49 AM.

Details

Reviewers
MaskRay
Commits
rG9f5d881206ce: [NFC] Correct argument comment typo
Summary

For Darwin, the boolean being passed is called IsSimulator, not "IsImulator"

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Dec 7 2022, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 8:49 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
gAlfonso-bit requested review of this revision.Dec 7 2022, 8:49 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptDec 7 2022, 8:49 AM
gAlfonso-bit added a comment.Dec 7 2022, 2:45 PM

@MaskRay This should be a quickie

MaskRay accepted this revision.Dec 7 2022, 4:09 PM
This revision is now accepted and ready to land.Dec 7 2022, 4:09 PM
Harbormaster completed remote builds in B201717: Diff 480934.Dec 7 2022, 6:16 PM
gAlfonso-bit added a comment.Dec 8 2022, 8:51 AM

@MaskRay How may I get commit permissions if I may ask?

gAlfonso-bit added a comment.Jan 25 2023, 11:10 AM

@MaskRay Could you please commit this for me

Closed by commit rG9f5d881206ce: [NFC] Correct argument comment typo (authored by gAlfonso-bit, committed by MaskRay). · Explain WhyJan 30 2023, 4:06 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG9f5d881206ce: [NFC] Correct argument comment typo.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
2 lines

Diff 480934

clang/lib/Driver/ToolChains/Darwin.cpp

Show First 20 Lines • Show All 1,759 Lines • ▼ Show 20 Lines if (macOSVersion) {
if (iOSVersion || TvOSVersion || WatchOSVersion) { if (iOSVersion || TvOSVersion || WatchOSVersion) {
TheDriver.Diag(diag::err_drv_argument_not_allowed_with) TheDriver.Diag(diag::err_drv_argument_not_allowed_with)
<< macOSVersion->getAsString(Args) << macOSVersion->getAsString(Args)
<< (iOSVersion ? iOSVersion << (iOSVersion ? iOSVersion
: TvOSVersion ? TvOSVersion : WatchOSVersion) : TvOSVersion ? TvOSVersion : WatchOSVersion)
->getAsString(Args); ->getAsString(Args);
} }
return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion, return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion,
/*IsImulator=*/false); /*IsSimulator=*/false);
} else if (iOSVersion) { } else if (iOSVersion) {
if (TvOSVersion || WatchOSVersion) { if (TvOSVersion || WatchOSVersion) {
TheDriver.Diag(diag::err_drv_argument_not_allowed_with) TheDriver.Diag(diag::err_drv_argument_not_allowed_with)
<< iOSVersion->getAsString(Args) << iOSVersion->getAsString(Args)
<< (TvOSVersion ? TvOSVersion : WatchOSVersion)->getAsString(Args); << (TvOSVersion ? TvOSVersion : WatchOSVersion)->getAsString(Args);
} }
return DarwinPlatform::createOSVersionArg( return DarwinPlatform::createOSVersionArg(
Darwin::IPhoneOS, iOSVersion, Darwin::IPhoneOS, iOSVersion,
▲ Show 20 Lines • Show All 1,516 Lines • Show Last 20 Lines