This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Update PatFrag definition in documentation
ClosedPublic

Authored by luke on Dec 7 2022, 5:05 AM.

Details

Summary

The old definition for store was outdated

Diff Detail

Event Timeline

luke created this revision.Dec 7 2022, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 5:05 AM
luke requested review of this revision.Dec 7 2022, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 5:05 AM
asb added inline comments.Dec 8 2022, 6:10 AM
llvm/docs/WritingAnLLVMBackend.rst
1314

How about "the DAG operator for store is defined below (alongside the definitions it depends on):" so it's less confusing why we're listing st and unindexedstore as well?

I note that the previous version had st without including it's definition, I'm in two minds as to whether it's worth including it (as you do in your patch) or not...

luke updated this revision to Diff 481470.EditedDec 8 2022, 4:05 PM

Remove dependent definitions, keep it succinct

luke marked an inline comment as done.Dec 8 2022, 4:05 PM
asb accepted this revision.Dec 9 2022, 1:54 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 9 2022, 1:54 AM
This revision was landed with ongoing or failed builds.Dec 9 2022, 1:56 AM
This revision was automatically updated to reflect the committed changes.