This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Make get_test_cc_for_arch() complain on accidental extra args
ClosedPublic

Authored by thakis on Dec 6 2022, 7:29 AM.

Details

Diff Detail

Event Timeline

thakis created this revision.Dec 6 2022, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 7:29 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
thakis requested review of this revision.Dec 6 2022, 7:29 AM

Maybe there's a better way to say "this macro should take no varargs"?

dvyukov accepted this revision.Dec 6 2022, 7:33 AM

I don't have cmake readability, but looks reasonable.
Better to merge after the fix for metadata tests.

This revision is now accepted and ready to land.Dec 6 2022, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 5:34 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript