This is an archive of the discontinued LLVM Phabricator instance.

Differential D139323

compiler-rt/test/metadata: restrict tests to x86_64
ClosedPublic

Authored by dvyukov on Dec 5 2022, 6:18 AM.

Details

Reviewers
melver
Commits
rG08742e72a34e: compiler-rt/test/metadata: restrict tests to x86_64
Summary

aarch64 builder broke with:

  • Supported architectures for crt: aarch64

CMake Error at compiler-rt/cmake/config-ix.cmake:244 (message):

Unsupported architecture: x86_64

Call Stack (most recent call first):

compiler-rt/cmake/config-ix.cmake:280 (get_target_flags_for_arch)
compiler-rt/test/metadata/CMakeLists.txt:7 (get_test_cc_for_arch)
  • Configuring incomplete, errors occurred!

https://lab.llvm.org/buildbot/#/builders/223/builds/11423

Restrict the tests to x86_64 only.

Diff Detail

Event Timeline

dvyukov created this revision.Dec 5 2022, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 6:18 AM
Herald added subscribers: Enna1, pengfei, kristof.beyls, dberris. · View Herald Transcript
dvyukov requested review of this revision.Dec 5 2022, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 6:18 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov mentioned this in D136078: Use-after-return sanitizer binary metadata.Dec 5 2022, 6:18 AM
melver accepted this revision.Dec 5 2022, 6:22 AM
This revision is now accepted and ready to land.Dec 5 2022, 6:22 AM
This revision was landed with ongoing or failed builds.Dec 5 2022, 6:27 AM
Closed by commit rG08742e72a34e: compiler-rt/test/metadata: restrict tests to x86_64 (authored by dvyukov). · Explain Why
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rG08742e72a34e: compiler-rt/test/metadata: restrict tests to x86_64.
Harbormaster completed remote builds in B201100: Diff 480085.Dec 5 2022, 7:44 AM

Revision Contents

PathSize
compiler-rt/
test/
metadata/
26 lines

Diff 480091

compiler-rt/test/metadata/CMakeLists.txt

if(CAN_TARGET_x86_64)
set(TEST_ARCH ${X86_64}) set(TEST_ARCH ${X86_64})
set(METADATA_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(METADATA_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(METADATA_LIT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) set(METADATA_LIT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
set(SANITIZER_COMMON_TEST_TARGET_ARCH ${X86_64}) set(SANITIZER_COMMON_TEST_TARGET_ARCH ${X86_64})
get_test_cc_for_arch(${X86_64} METADATA_TEST_TARGET_CC METADATA_TEST_TARGET_CFLAGS) get_test_cc_for_arch(${X86_64} METADATA_TEST_TARGET_CC METADATA_TEST_TARGET_CFLAGS)
configure_lit_site_cfg( configure_lit_site_cfg(
${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py) ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py)
add_lit_testsuite(check-sanmd "Running the SanitizerBinaryMetadata tests" add_lit_testsuite(check-sanmd "Running the SanitizerBinaryMetadata tests"
${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR}
DEPENDS ${SANITIZER_COMMON_LIT_TEST_DEPS}) DEPENDS ${SANITIZER_COMMON_LIT_TEST_DEPS})
set_target_properties(check-sanmd PROPERTIES FOLDER "Compiler-RT Misc") set_target_properties(check-sanmd PROPERTIES FOLDER "Compiler-RT Misc")
endif()