[NFC] Moved definition of BasicBlock::Create() to BasicBlock.cpp.

[aeubanks]

what's the reason behind this?

also nit on commit titles, use present tense (Move definition ...) and omit trailing period

[vporpo]

It is not super necessary, but it will make some follow-up patches more readable.

[aeubanks]

this might slow down llvm for people who don't use LTO to build llvm? keep an eye on llvm-compile-time-tracker

[vporpo]

Good point. I will abandon this for now. Let me see what I can do to avoid moving this to the cpp file.

llvm/include/llvm/IR/BasicBlock.h

public:
 
   /// Creates a new BasicBlock.
   ///
   /// If the Parent parameter is specified, the basic block is automatically
   /// inserted at either the end of the function (if InsertBefore is 0), or
   /// before the specified basic block.
   static BasicBlock *Create(LLVMContext &Context, const Twine &Name = "",
                             Function *Parent = nullptr,
-                            BasicBlock *InsertBefore = nullptr) {
-    return new BasicBlock(Context, Name, Parent, InsertBefore);
-  }
+                            BasicBlock *InsertBefore = nullptr);
 
   /// Return the enclosing method, or null if none.
   const Function *getParent() const { return Parent; }
         Function *getParent()       { return Parent; }
 
   /// Return the module owning the function this basic block belongs to, or
   /// nullptr if the function does not have a module.
   ///

llvm/lib/IR/BasicBlock.cpp

if (Function *F = getParent())
     return F->getValueSymbolTable();
   return nullptr;
 }
 
 LLVMContext &BasicBlock::getContext() const {
   return getType()->getContext();
 }
 
+BasicBlock *BasicBlock::Create(LLVMContext &Context, const Twine &Name,
+                               Function *Parent, BasicBlock *InsertBefore) {
+  return new BasicBlock(Context, Name, Parent, InsertBefore);
+}
+
 template <> void llvm::invalidateParentIListOrdering(BasicBlock *BB) {
   BB->invalidateOrders();
 }
 
 // Explicit instantiation of SymbolTableListTraits since some of the methods
 // are not in the public header file...
 template class llvm::SymbolTableListTraits<Instruction>;