Add extra parameter type check to musttail callsite to avoid verifier error.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail_typecheck.ll | ||
---|---|---|
30 | I would like to see more of the successfully transformed IR, I want to see if the musttail call is in the tail position, since that's also a verifier requirement. Can we use https://github.com/llvm/llvm-project/blob/main/llvm/utils/update_test_checks.py for this test? There's not too much extraneous IR. |
lgtm with a couple comment suggestions for test
llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail_typecheck.ll | ||
---|---|---|
13 | Add comment that we are checking that there was no icp due to parameter mismatch. | |
34 | Add comment that we are checking that icp succeeded since the parameter types match and that the promoted call is also musttail. |
Add comment that we are checking that there was no icp due to parameter mismatch.