[test-suite][tsvc] Use fabs in s318 and s3113

[SjoerdMeijer]

Summary

In the s318 and s3113 kernels, the integer variant of the abs() function was to determined the absolute value. It operates on a float value, and the result is stored in a variable max which has the float type, which makes me think the intention here was to use fabs() variant, not the integer abs() variant.

[SjoerdMeijer]

MultiSource/Benchmarks/TSVC/types.h

12

This is not entirely ideal to always use the double precision variant in the else-case, but we only generate float and double variants of the kernels (not integers), so didn't feel like making it more complicated than this.

[rengolin]

LGTM, thanks!

MultiSource/Benchmarks/TSVC/tsc.inc

3778

UFF! This should really be CLOCKS_PER_SEC... But it's ok to make that a sweeping mechanical change on another patch.

[SjoerdMeijer]

MultiSource/Benchmarks/TSVC/tsc.inc

3778

Wowsers!!! Good catch.
This is fine though if we divide by the same random number everywhere. ;-)

But while I am at it, I could do the find and replace as a follow up.

MultiSource/Benchmarks/TSVC/tsc.inc

//  isamax, max absolute value, increments not equal to 1
   init( "s318 ");
   start_t = clock();
 
   int k, index;
   TYPE max, chksum;
   for (int nl = 0; nl < ntimes/2; nl++) {
     k = 0;
     index = 0;
-    max = abs(a[0]);
+    max = FABS(a[0]);
     k += inc;
     for (int i = 1; i < LEN; i++) {
-      if (abs(a[k]) <= max) {
+      if (FABS(a[k]) <= max) {
         goto L5;
       }
       index = i;
-      max = abs(a[k]);
+      max = FABS(a[k]);
 L5:
       k += inc;
     }
     chksum = max + (TYPE) index;
     dummy(a, b, c, d, e, aa, bb, cc, chksum);
   }
   end_t = clock(); clock_dif = end_t - start_t;
   clock_dif_sec = (double) (clock_dif/1000000.0);
   printf("S318\t %.2f \t\t", clock_dif_sec);;
   temp = max + index+1;
   check(-1);
   return 0;
 }
 
 // %3.1
 
//  maximum of absolute value
   clock_t start_t, end_t, clock_dif; double clock_dif_sec;
 
 
   init( "s3113");
   start_t = clock();
 
   TYPE max;
   for (int nl = 0; nl < ntimes*4; nl++) {
-    max = abs(a[0]);
+    max = FABS(a[0]);
     for (int i = 0; i < LEN; i++) {
-      if ((abs(a[i])) > max) {
-        max = abs(a[i]);
+      if ((FABS(a[i])) > max) {
+        max = FABS(a[i]);
       }
     }
     dummy(a, b, c, d, e, aa, bb, cc, max);
   }
   end_t = clock(); clock_dif = end_t - start_t;
   clock_dif_sec = (double) (clock_dif/1000000.0);
   printf("S3113\t %.2f \t\t", clock_dif_sec);;
   temp = max;

MultiSource/Benchmarks/TSVC/types.h

 #ifndef TYPES_H
 #define TYPES_H
 
 #define LEN 32000
 #define LEN2 256
 
 #ifndef TYPE
   #define TYPE float
+  #define FABS(x) fabsf(x)
+#else
+  #define FABS(x) fabs(x)
 #endif
 
 #ifndef X_TYPE
   #define X_TYPE TYPE
 #endif
 
 #ifndef ALIGNMENT
 #define ALIGNMENT 16
 #endif
 
 #endif // TYPES_H