[libc++] Install llvm-dev in the docker image

[philnik]

Summary

This is required to compile custom clang-tidy checks

[Mordante]

Thanks for working on this!

libcxx/utils/ci/Dockerfile

88

I would prefer to install $(($LLVM_HEAD_VERSION - 1)) add $(($LLVM_HEAD_VERSION - 2)). Then we use released versions of clang-tidy headers instead of the development version. We do the same for clang-tidy itself.

[philnik]

Address comments

[Mordante]

Thanks LGTM!

libcxx/utils/ci/Dockerfile

 RUN ln -s /usr/bin/clang-format-14 /usr/bin/clang-format && [ -e $(readlink /usr/bin/clang-format) ]
 RUN ln -s /usr/bin/git-clang-format-14 /usr/bin/git-clang-format && [ -e $(readlink /usr/bin/git-clang-format) ]
 
 # Install clang-tidy
 # TODO LLVM 16 remove hard-coded version 14 and the symlink
 RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION clang-tidy-14
 RUN ln -s /usr/bin/clang-tidy-14 /usr/bin/clang-tidy && [ -e $(readlink /usr/bin/clang-tidy) ]
 
+# Install llvm-dev to compile custom clang-tidy checks
+RUN apt-get update && apt-get install llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev
+
 # Install clang-tools
 RUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 1)) clang-tools-$LLVM_HEAD_VERSION
 
 # Install the most recent GCC, like clang install the previous version as a transition.
 ENV GCC_LATEST_VERSION=12
 RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1))
 RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION