Page MenuHomePhabricator

[libc++] Install llvm-dev in the docker image
ClosedPublic

Authored by philnik on Nov 25 2022, 9:25 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rGf48f9614536c: [libc++] Install llvm-dev in the docker image
Summary

This is required to compile custom clang-tidy checks

Diff Detail

Event Timeline

philnik created this revision.Nov 25 2022, 9:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2022, 9:25 AM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik requested review of this revision.Nov 25 2022, 9:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2022, 9:25 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks for working on this!

libcxx/utils/ci/Dockerfile
88

I would prefer to install $(($LLVM_HEAD_VERSION - 1)) add $(($LLVM_HEAD_VERSION - 2)). Then we use released versions of clang-tidy headers instead of the development version. We do the same for clang-tidy itself.

philnik updated this revision to Diff 478650.Nov 29 2022, 11:08 AM
philnik marked an inline comment as done.

Address comments

Mordante accepted this revision.Nov 29 2022, 12:01 PM

Thanks LGTM!

This revision is now accepted and ready to land.Nov 29 2022, 12:01 PM
This revision was landed with ongoing or failed builds.Nov 29 2022, 3:49 PM
This revision was automatically updated to reflect the committed changes.