This is an archive of the discontinued LLVM Phabricator instance.

Differential D138535

[AVR] Add $ separator string (like avr-gcc)
ClosedPublic

Authored by aykevl on Nov 22 2022, 5:12 PM.

Details

Reviewers
dylanmckay
benshi001
compnerd
Commits
rG3b2b83ce2f6b: [AVR] Add $ separator string (like avr-gcc)
Summary

avr-gcc uses the $ symbol as an assembly separator instead of the more common %% syntax. We need it in LLVM too to be compatible.

Diff Detail

Event Timeline

aykevl created this revision.Nov 22 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 5:12 PM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
aykevl requested review of this revision.Nov 22 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 5:12 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aykevl mentioned this in D138166: [compiler-rt][builtins] Add AVR __udivmodsi4 and __divmodsi4.Nov 22 2022, 5:18 PM
Harbormaster completed remote builds in B199090: Diff 477350.Nov 22 2022, 6:09 PM
benshi001 accepted this revision.Nov 24 2022, 10:57 PM

LGTM. This is in accordance with avr-gcc. Thanks.

This revision is now accepted and ready to land.Nov 24 2022, 10:57 PM
Closed by commit rG3b2b83ce2f6b: [AVR] Add $ separator string (like avr-gcc) (authored by aykevl). · Explain WhyNov 27 2022, 6:31 AM
This revision was automatically updated to reflect the committed changes.
aykevl added a commit: rG3b2b83ce2f6b: [AVR] Add $ separator string (like avr-gcc).

Revision Contents

PathSize
llvm/
lib/
Target/
AVR/
MCTargetDesc/
1 line
test/
MC/
AVR/
11 lines

Diff 478093

llvm/lib/Target/AVR/MCTargetDesc/AVRMCAsmInfo.cpp

Show All 14 Lines
#include "llvm/ADT/Triple.h" #include "llvm/ADT/Triple.h"
namespace llvm { namespace llvm {
AVRMCAsmInfo::AVRMCAsmInfo(const Triple &TT, const MCTargetOptions &Options) { AVRMCAsmInfo::AVRMCAsmInfo(const Triple &TT, const MCTargetOptions &Options) {
CodePointerSize = 2; CodePointerSize = 2;
CalleeSaveStackSlotSize = 2; CalleeSaveStackSlotSize = 2;
CommentString = ";"; CommentString = ";";
SeparatorString = "$";
PrivateGlobalPrefix = ".L"; PrivateGlobalPrefix = ".L";
PrivateLabelPrefix = ".L"; PrivateLabelPrefix = ".L";
UsesELFSectionDirectiveForBSS = true; UsesELFSectionDirectiveForBSS = true;
SupportsDebugInformation = true; SupportsDebugInformation = true;
} }
} // end of namespace llvm } // end of namespace llvm

llvm/test/MC/AVR/separator.s

  • This file was added.
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck %s
foo:
; The $ symbol is a separator (like a newline).
mov r0, r1 $ mov r1, r2 $ mov r2, r3 $ mov r3, r4
; CHECK: mov r0, r1
; CHECK: mov r1, r2
; CHECK: mov r2, r3
; CHECK: mov r3, r4