[libc++][NFC] Remove unused include in __threading_support
ClosedPublic

Authored by ldionne on Nov 22 2022, 3:11 PM.

Download Raw Diff

Details

Reviewers

EricWF

Group Reviewers

Restricted Project

Commits

rGe375fd0343e4: [libc++] Remove unused include in __threading_support

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	2,960 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
	2,960 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
	2,960 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
	2,960 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
	2,960 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
		View Full Test Results (40,000 Failed)

Event Timeline

ldionne created this revision.Nov 22 2022, 3:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM

ldionne requested review of this revision.Nov 22 2022, 3:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B199067: Diff 477318.Nov 22 2022, 3:49 PM

Fixup transitive includes

Harbormaster completed remote builds in B199200: Diff 477495.Nov 23 2022, 7:06 AM

Rebase

Harbormaster completed remote builds in B199208: Diff 477503.Nov 23 2022, 8:46 AM

Try to fix CI

Herald added a subscriber: arichardson. · View Herald TranscriptNov 25 2022, 8:24 AM

Fix win32 build

Rebase and remove temporary CI hack

Harbormaster completed remote builds in B199579: Diff 477996.Nov 25 2022, 10:51 AM

LGTM.

This revision is now accepted and ready to land.May 17 2023, 10:06 AM

Rebase and poke CI.

Harbormaster completed remote builds in B256098: Diff 555149.Aug 31 2023, 7:36 PM

Fix missing include and C++03 issue.

CI passed but updating the Phabricator status timed out. Shipping.

This revision was landed with ongoing or failed builds.Sep 6 2023, 6:39 AM

Closed by commit rGe375fd0343e4: [libc++] Remove unused include in __threading_support (authored by ldionne). · Explain Why

This revision was automatically updated to reflect the committed changes.

ldionne added a commit: rGe375fd0343e4: [libc++] Remove unused include in __threading_support.

Revision Contents

Path

Size

libcxx/

include/

__threading_support

4 lines

src/

support/

win32/

thread_win32.cpp

2 lines

Diff 477996

libcxx/include/__threading_support

	Show All 10 Lines
	#define _LIBCPP___THREADING_SUPPORT			#define _LIBCPP___THREADING_SUPPORT

	#include <__availability>			#include <__availability>
	#include <__chrono/convert_to_timespec.h>			#include <__chrono/convert_to_timespec.h>
	#include <__chrono/duration.h>			#include <__chrono/duration.h>
	#include <__compare/ordering.h>			#include <__compare/ordering.h>
	#include <__config>			#include <__config>
	#include <__fwd/hash.h>			#include <__fwd/hash.h>
	#include <__thread/poll_with_backoff.h>			#include <ctime>
	#include <errno.h>			#include <errno.h>
	#include <iosfwd>			#include <iosfwd>
	#include <limits>			#include <limits>

	#ifdef __MVS__			#ifdef __MVS__
	# include <__support/ibm/nanosleep.h>			# include <__support/ibm/nanosleep.h>
	#endif			#endif

	Show All 21 Lines
	#endif			#endif

	#if defined(__FreeBSD__) && defined(__clang__) && __has_attribute(no_thread_safety_analysis)			#if defined(__FreeBSD__) && defined(__clang__) && __has_attribute(no_thread_safety_analysis)
	#define _LIBCPP_NO_THREAD_SAFETY_ANALYSIS __attribute__((no_thread_safety_analysis))			#define _LIBCPP_NO_THREAD_SAFETY_ANALYSIS __attribute__((no_thread_safety_analysis))
	#else			#else
	#define _LIBCPP_NO_THREAD_SAFETY_ANALYSIS			#define _LIBCPP_NO_THREAD_SAFETY_ANALYSIS
	#endif			#endif

	typedef ::timespec __libcpp_timespec_t;			typedef std::timespec __libcpp_timespec_t;
	#endif // !defined(_LIBCPP_HAS_NO_THREADS)			#endif // !defined(_LIBCPP_HAS_NO_THREADS)

	_LIBCPP_BEGIN_NAMESPACE_STD			_LIBCPP_BEGIN_NAMESPACE_STD

	#if !defined(_LIBCPP_HAS_NO_THREADS)			#if !defined(_LIBCPP_HAS_NO_THREADS)

	#if defined(_LIBCPP_HAS_THREAD_API_PTHREAD)			#if defined(_LIBCPP_HAS_THREAD_API_PTHREAD)
	// Mutex			// Mutex
	▲ Show 20 Lines • Show All 641 Lines • Show Last 20 Lines

libcxx/src/support/win32/thread_win32.cpp

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	//			//
	// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.			// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
	// See https://llvm.org/LICENSE.txt for license information.			// See https://llvm.org/LICENSE.txt for license information.
	// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception			// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	#include <__threading_support>			#include <__threading_support>
				#include <chrono>

	#define NOMINMAX			#define NOMINMAX
	#define WIN32_LEAN_AND_MEAN			#define WIN32_LEAN_AND_MEAN
	#include <windows.h>			#include <windows.h>
	#include <process.h>			#include <process.h>
	#include <fibersapi.h>			#include <fibersapi.h>

	_LIBCPP_BEGIN_NAMESPACE_STD			_LIBCPP_BEGIN_NAMESPACE_STD

	▲ Show 20 Lines • Show All 257 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Remove unused include in __threading_supportClosedPublic