[libc++][NFC] Remove unused include in __threading_support
ClosedPublic

Authored by ldionne on Nov 22 2022, 3:11 PM.

Download Raw Diff

Details

Reviewers

EricWF

Group Reviewers

Restricted Project

Commits

rGe375fd0343e4: [libc++] Remove unused include in __threading_support

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	13,590 ms	libcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_cons::path.pass.cpp
	12,770 ms	libcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::assign.pass.cpp
	13,890 ms	libcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::refresh.pass.cpp
	13,230 ms	libcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::replace_filename.pass.cpp
	14,010 ms	libcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_obs::file_size.pass.cpp
		View Full Test Results (54 Failed)

Event Timeline

ldionne created this revision.Nov 22 2022, 3:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM

ldionne requested review of this revision.Nov 22 2022, 3:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B199067: Diff 477318.Nov 22 2022, 3:49 PM

Fixup transitive includes

Harbormaster completed remote builds in B199200: Diff 477495.Nov 23 2022, 7:06 AM

Rebase

Harbormaster completed remote builds in B199208: Diff 477503.Nov 23 2022, 8:46 AM

Try to fix CI

Herald added a subscriber: arichardson. · View Herald TranscriptNov 25 2022, 8:24 AM

Fix win32 build

Rebase and remove temporary CI hack

Harbormaster completed remote builds in B199579: Diff 477996.Nov 25 2022, 10:51 AM

LGTM.

This revision is now accepted and ready to land.May 17 2023, 10:06 AM

Rebase and poke CI.

Harbormaster completed remote builds in B256098: Diff 555149.Aug 31 2023, 7:36 PM

Fix missing include and C++03 issue.

CI passed but updating the Phabricator status timed out. Shipping.

This revision was landed with ongoing or failed builds.Sep 6 2023, 6:39 AM

Closed by commit rGe375fd0343e4: [libc++] Remove unused include in __threading_support (authored by ldionne). · Explain Why

This revision was automatically updated to reflect the committed changes.

ldionne added a commit: rGe375fd0343e4: [libc++] Remove unused include in __threading_support.

Revision Contents

Path

Size

libcxx/

include/

__threading_support

1 line

barrier

1 line

semaphore

4 lines

test/

libcxx/

transitive_includes/

cxx2b.csv

2 lines

Diff 477503

libcxx/include/__threading_support

	Show All 10 Lines
	#define _LIBCPP___THREADING_SUPPORT			#define _LIBCPP___THREADING_SUPPORT

	#include <__availability>			#include <__availability>
	#include <__chrono/convert_to_timespec.h>			#include <__chrono/convert_to_timespec.h>
	#include <__chrono/duration.h>			#include <__chrono/duration.h>
	#include <__compare/ordering.h>			#include <__compare/ordering.h>
	#include <__config>			#include <__config>
	#include <__fwd/hash.h>			#include <__fwd/hash.h>
	#include <__thread/poll_with_backoff.h>
	#include <errno.h>			#include <errno.h>
	#include <iosfwd>			#include <iosfwd>
	#include <limits>			#include <limits>

	#ifdef __MVS__			#ifdef __MVS__
	# include <__support/ibm/nanosleep.h>			# include <__support/ibm/nanosleep.h>
	#endif			#endif

	▲ Show 20 Lines • Show All 679 Lines • Show Last 20 Lines

libcxx/include/barrier

	Show First 20 Lines • Show All 324 Lines • ▼ Show 20 Lines
	_LIBCPP_END_NAMESPACE_STD			_LIBCPP_END_NAMESPACE_STD

	#endif // _LIBCPP_STD_VER >= 14			#endif // _LIBCPP_STD_VER >= 14

	_LIBCPP_POP_MACROS			_LIBCPP_POP_MACROS

	#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20			#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
	# include <concepts>			# include <concepts>
				# include <ctime>
	# include <iterator>			# include <iterator>
	# include <memory>			# include <memory>
	# include <stdexcept>			# include <stdexcept>
	# include <variant>			# include <variant>
	#endif			#endif

	#endif //_LIBCPP_BARRIER			#endif //_LIBCPP_BARRIER

libcxx/include/semaphore

	Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines
	using binary_semaphore = counting_semaphore<1>;			using binary_semaphore = counting_semaphore<1>;

	_LIBCPP_END_NAMESPACE_STD			_LIBCPP_END_NAMESPACE_STD

	#endif // _LIBCPP_STD_VER >= 14			#endif // _LIBCPP_STD_VER >= 14

	_LIBCPP_POP_MACROS			_LIBCPP_POP_MACROS

				#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
				# include <ctime>
				#endif

	#endif //_LIBCPP_SEMAPHORE			#endif //_LIBCPP_SEMAPHORE

libcxx/test/libcxx/transitive_includes/cxx2b.csv

	Show All 36 Lines
	atomic limits			atomic limits
	atomic ratio			atomic ratio
	atomic type_traits			atomic type_traits
	atomic version			atomic version
	barrier atomic			barrier atomic
	barrier cstddef			barrier cstddef
	barrier cstdint			barrier cstdint
	barrier cstring			barrier cstring
	barrier ctime
	barrier iosfwd			barrier iosfwd
	barrier limits			barrier limits
	barrier new			barrier new
	barrier ratio			barrier ratio
	barrier type_traits			barrier type_traits
	bit cstdint			bit cstdint
	bit cstdlib			bit cstdlib
	bit limits			bit limits
	▲ Show 20 Lines • Show All 495 Lines • ▼ Show 20 Lines
	regex version			regex version
	scoped_allocator cstddef			scoped_allocator cstddef
	scoped_allocator limits			scoped_allocator limits
	scoped_allocator new			scoped_allocator new
	scoped_allocator tuple			scoped_allocator tuple
	scoped_allocator type_traits			scoped_allocator type_traits
	scoped_allocator version			scoped_allocator version
	semaphore atomic			semaphore atomic
	semaphore ctime
	semaphore iosfwd			semaphore iosfwd
	semaphore limits			semaphore limits
	semaphore ratio			semaphore ratio
	semaphore type_traits			semaphore type_traits
	semaphore version			semaphore version
	set compare			set compare
	set cstddef			set cstddef
	set cstdlib			set cstdlib
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Remove unused include in __threading_supportClosedPublic