This is an archive of the discontinued LLVM Phabricator instance.

Differential D138528

[libc++][NFC] Remove unused include in __threading_support
ClosedPublic

Authored by ldionne on Nov 22 2022, 3:11 PM.

Details

Reviewers
EricWF
Group Reviewers
Restricted Project
Commits
rGe375fd0343e4: [libc++] Remove unused include in __threading_support

Diff Detail

Event Timeline

ldionne created this revision.Nov 22 2022, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM
ldionne requested review of this revision.Nov 22 2022, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2022, 3:11 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B199067: Diff 477318.Nov 22 2022, 3:49 PM
ldionne updated this revision to Diff 477495.Nov 23 2022, 6:59 AM

Fixup transitive includes

Harbormaster completed remote builds in B199200: Diff 477495.Nov 23 2022, 7:06 AM
ldionne updated this revision to Diff 477503.Nov 23 2022, 7:31 AM

Rebase

Harbormaster completed remote builds in B199208: Diff 477503.Nov 23 2022, 8:46 AM
ldionne updated this revision to Diff 477973.Nov 25 2022, 8:24 AM

Try to fix CI

Herald added a subscriber: arichardson. · View Herald TranscriptNov 25 2022, 8:24 AM
ldionne updated this revision to Diff 477984.Nov 25 2022, 8:51 AM

Fix win32 build

ldionne updated this revision to Diff 477996.Nov 25 2022, 9:53 AM

Rebase and remove temporary CI hack

Harbormaster completed remote builds in B199579: Diff 477996.Nov 25 2022, 10:51 AM
EricWF accepted this revision.May 17 2023, 10:06 AM
EricWF added a subscriber: EricWF.

LGTM.

This revision is now accepted and ready to land.May 17 2023, 10:06 AM
ldionne updated this revision to Diff 555149.Aug 31 2023, 1:08 PM

Rebase and poke CI.

Harbormaster completed remote builds in B256098: Diff 555149.Aug 31 2023, 7:36 PM
ldionne updated this revision to Diff 555906.Sep 5 2023, 11:23 AM

Fix missing include and C++03 issue.

ldionne added a comment.Sep 6 2023, 6:39 AM

CI passed but updating the Phabricator status timed out. Shipping.

This revision was landed with ongoing or failed builds.Sep 6 2023, 6:39 AM
Closed by commit rGe375fd0343e4: [libc++] Remove unused include in __threading_support (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGe375fd0343e4: [libc++] Remove unused include in __threading_support.

Revision Contents

PathSize
libcxx/
include/
3 lines
1 line
src/
support/
win32/
2 lines

Diff 556026

libcxx/include/__threading_support

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___THREADING_SUPPORT #ifndef _LIBCPP___THREADING_SUPPORT
#define _LIBCPP___THREADING_SUPPORT #define _LIBCPP___THREADING_SUPPORT
#include <__availability> #include <__availability>
#include <__chrono/convert_to_timespec.h> #include <__chrono/convert_to_timespec.h>
#include <__chrono/duration.h> #include <__chrono/duration.h>
#include <__config> #include <__config>
#include <__thread/poll_with_backoff.h> #include <__fwd/hash.h>
#include <ctime>
#include <errno.h> #include <errno.h>
#ifdef __MVS__ #ifdef __MVS__
# include <__support/ibm/nanosleep.h> # include <__support/ibm/nanosleep.h>
#endif #endif
#ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER #ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
# pragma GCC system_header # pragma GCC system_header
▲ Show 20 Lines • Show All 564 Lines • Show Last 20 Lines

libcxx/include/semaphore

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__atomic/atomic_base.h> #include <__atomic/atomic_base.h>
#include <__atomic/atomic_sync.h> #include <__atomic/atomic_sync.h>
#include <__atomic/memory_order.h> #include <__atomic/memory_order.h>
#include <__availability> #include <__availability>
#include <__chrono/time_point.h> #include <__chrono/time_point.h>
#include <__config> #include <__config>
#include <__thread/poll_with_backoff.h>
#include <__thread/timed_backoff_policy.h> #include <__thread/timed_backoff_policy.h>
#include <__threading_support> #include <__threading_support>
#include <cstddef> #include <cstddef>
#include <limits> #include <limits>
#include <version> #include <version>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
▲ Show 20 Lines • Show All 154 Lines • Show Last 20 Lines

libcxx/src/support/win32/thread_win32.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <__threading_support> #include <__threading_support>
#include <chrono>
#define NOMINMAX #define NOMINMAX
#define WIN32_LEAN_AND_MEAN #define WIN32_LEAN_AND_MEAN
#include <windows.h> #include <windows.h>
#include <process.h> #include <process.h>
#include <fibersapi.h> #include <fibersapi.h>
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 257 Lines • Show Last 20 Lines