Page MenuHomePhabricator
Differential D138472

clang/cmake: Use installed gtest libraries for stand-alone builds
ClosedPublic
Actions

Authored by tstellar on Nov 21 2022, 9:11 PM.

Details

Reviewers
mgorny
phosek
Ericson2314
kwk
Commits
rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds

Diff Detail

Event Timeline

tstellar created this revision.Nov 21 2022, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 9:11 PM
tstellar requested review of this revision.Nov 21 2022, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 9:11 PM
tstellar mentioned this in D137890: Add install targets for gtest.Nov 21 2022, 9:12 PM
Harbormaster completed remote builds in B198896: Diff 477058.Nov 21 2022, 9:12 PM
kwk added a subscriber: kwk.Nov 22 2022, 2:38 AM
kwk added inline comments.
clang/CMakeLists.txt
120–121

I don't see no FindLLVMGTest.cmake file anywhere. Is that suppose to exist yet or which Patch is suppose to create it?

tstellar added inline comments.Nov 22 2022, 7:52 AM
clang/CMakeLists.txt
120–121

It's added in D137890. And it's called LLVMGTestConfig.cmake.

kwk accepted this revision.Jan 25 2023, 8:48 AM

Working for me.

This revision is now accepted and ready to land.Jan 25 2023, 8:48 AM
phosek accepted this revision.Jan 25 2023, 9:45 AM

LGTM

This revision was landed with ongoing or failed builds.Fri, Mar 10, 8:01 PM
Closed by commit rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds.

Revision Contents
Changeset List

PathSize
clang/
22 lines

Diff 504328

View Options

clang/CMakeLists.txt

Loading...