[llvm-mca] Fix class dominance warnings for parseCodeRegions

[michaelmaitland]

Summary

Fixes issue 59091.

CodeRegionGenerator::parseCodeRegions is implemented by AsmCodeRegionGenerator.
If it were to be implemented in AnalysisRegionGenerator or InstrumentRegionGenerator,
then parseCodeRegions from an AsmAnalysisRegionGenerator or AsmInstrumentRegionGenerator
object would be ambiguous. To solve this, AsmAnalysisRegionGenerator and
AsmInstrumentRegionGenerator qualify their call to AsmCodeRegionGenerator::parseCodeRegions.

[michaelmaitland]

@RKSimon, I'm not quite sure how to make one of these MSVC builds. But I used godbolt.org with the following snippet to verify the issue went away:

#include <stdio.h>
struct CRG {
   virtual void func() = 0;
};
struct AnalysisCRG : public virtual CRG {};
struct InstCRG : public virtual CRG {};
struct AsmCRG : public virtual CRG {
    void func() { printf("dominant::func\n"); }
};

struct AsmAnalysisCRG final : public AnalysisCRG, public AsmCRG {
     void func() { AsmCRG::func(); }
};
struct AsmInstCRG final : public InstCRG, public AsmCRG {
    void func() { AsmCRG::func(); }
};

int main() {
   AsmAnalysisCRG a;
   AsmInstCRG i;

   a.func();   // C4250 should go away now
   i.func(); // C4250 should go away now
}

[myhsu]

I just quickly tried this with /W3 on MSVC 2019 and the warning no longer appears. Cheers

llvm/tools/llvm-mca/CodeRegionGenerator.h

public:
   Expected<const AnalysisRegions &>
   parseAnalysisRegions(const std::unique_ptr<MCInstPrinter> &IP) override {
     Expected<const CodeRegions &> RegionsOrErr = parseCodeRegions(IP);
     if (!RegionsOrErr)
       return RegionsOrErr.takeError();
     else
       return static_cast<const AnalysisRegions &>(*RegionsOrErr);
   }
+
+  Expected<const CodeRegions &>
+  parseCodeRegions(const std::unique_ptr<MCInstPrinter> &IP) override {
+    return AsmCodeRegionGenerator::parseCodeRegions(IP);
+  }
 };
 
 class AsmInstrumentRegionGenerator final : public InstrumentRegionGenerator,
                                            public AsmCodeRegionGenerator {
   InstrumentRegionCommentConsumer CC;
 
 public:
   AsmInstrumentRegionGenerator(const Target &T, llvm::SourceMgr &SM,
public:
   Expected<const InstrumentRegions &>
   parseInstrumentRegions(const std::unique_ptr<MCInstPrinter> &IP) override {
     Expected<const CodeRegions &> RegionsOrErr = parseCodeRegions(IP);
     if (!RegionsOrErr)
       return RegionsOrErr.takeError();
     else
       return static_cast<const InstrumentRegions &>(*RegionsOrErr);
   }
+
+  Expected<const CodeRegions &>
+  parseCodeRegions(const std::unique_ptr<MCInstPrinter> &IP) override {
+    return AsmCodeRegionGenerator::parseCodeRegions(IP);
+  }
 };
 
 } // namespace mca
 } // namespace llvm
 
 #endif // LLVM_TOOLS_LLVM_MCA_CODEREGION_GENERATOR_H