This is an archive of the discontinued LLVM Phabricator instance.

Differential D138403

[LoongArch] Fix issue on CMake Xcode build configuration
ClosedPublic

Authored by gonglingqin on Nov 21 2022, 12:11 AM.

Download Raw Diff

Details

Reviewers

xen0n
xry111
SixWeining
wangleiat
MaskRay
XiaodongLoong
WowbaggersLiquidLunch

Commits

rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration

Summary

Add missing dependency for loongarch-resource-headers. This patch refers to D126892 to repair same error.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

gonglingqin created this revision.Nov 21 2022, 12:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 12:11 AM

Herald added a subscriber: StephenFan. · View Herald Transcript

gonglingqin requested review of this revision.Nov 21 2022, 12:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 12:11 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

gonglingqin added a reviewer: WowbaggersLiquidLunch.Nov 21 2022, 12:14 AM

gonglingqin mentioned this in D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin.Nov 21 2022, 12:17 AM

gonglingqin edited the summary of this revision. (Show Details)Nov 21 2022, 12:31 AM

LGTM but wait for @WowbaggersLiquidLunch.

This revision is now accepted and ready to land.Nov 21 2022, 12:34 AM

Yes this works! Thanks!

Harbormaster completed remote builds in B198726: Diff 476814.Nov 21 2022, 12:06 PM

This revision was landed with ongoing or failed builds.Nov 22 2022, 12:59 AM

Closed by commit rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration (authored by gonglingqin). · Explain Why

This revision was automatically updated to reflect the committed changes.

gonglingqin added a commit: rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration.

Revision Contents

Path

Size

clang/

lib/

Headers/

1 line

Diff 477094

clang/lib/Headers/CMakeLists.txt

	Show First 20 Lines • Show All 388 Lines • ▼ Show 20 Lines		add_dependencies("clang-resource-headers"
	"core-resource-headers"			"core-resource-headers"
	"arm-common-resource-headers"			"arm-common-resource-headers"
	"arm-resource-headers"			"arm-resource-headers"
	"aarch64-resource-headers"			"aarch64-resource-headers"
	"cuda-resource-headers"			"cuda-resource-headers"
	"hexagon-resource-headers"			"hexagon-resource-headers"
	"hip-resource-headers"			"hip-resource-headers"
	"hlsl-resource-headers"			"hlsl-resource-headers"
				"loongarch-resource-headers"
	"mips-resource-headers"			"mips-resource-headers"
	"ppc-resource-headers"			"ppc-resource-headers"
	"ppc-htm-resource-headers"			"ppc-htm-resource-headers"
	"riscv-resource-headers"			"riscv-resource-headers"
	"systemz-resource-headers"			"systemz-resource-headers"
	"ve-resource-headers"			"ve-resource-headers"
	"webassembly-resource-headers"			"webassembly-resource-headers"
	"x86-resource-headers"			"x86-resource-headers"
	▲ Show 20 Lines • Show All 276 Lines • Show Last 20 Lines