This is an archive of the discontinued LLVM Phabricator instance.

[libc][math] Remove UInt<128>::operation* specialization.
ClosedPublic

Authored by lntue on Nov 17 2022, 2:53 PM.

Details

Summary

Remove UInt<128>::operation* specialization since the generic implementation
works well enough:
https://quick-bench.com/q/Bz_J5HgAsz5m5V5Ze-X1fI77hPo

Diff Detail

Event Timeline

lntue created this revision.Nov 17 2022, 2:53 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 17 2022, 2:53 PM
lntue requested review of this revision.Nov 17 2022, 2:53 PM
lntue edited the summary of this revision. (Show Details)Nov 17 2022, 2:54 PM
sivachandra accepted this revision.Nov 17 2022, 3:04 PM
This revision is now accepted and ready to land.Nov 17 2022, 3:04 PM

Do you have a benchmark comparing the new implementation vs. this specialized implementation? It appears that you currently only have the new implementation and the old generic implementation.

lntue edited the summary of this revision. (Show Details)Nov 17 2022, 3:43 PM

Do you have a benchmark comparing the new implementation vs. this specialized implementation? It appears that you currently only have the new implementation and the old generic implementation.

I updated the benchmark to include the old specialized implementation.

This revision was automatically updated to reflect the committed changes.